feat: add admin backend foundation (login, session, health) by Ferryx349 · Pull Request #641 · cameri/nostream

Ferryx349 · 2026-06-07T08:15:49Z

Description

This is the groundwork for admin console backend with a disabled-by-default admin API. Currently with password login(will replace it with NIP-98 later). API also includes session management, and a protected health endpoint.

Related Issue

#631

Screenshots

On local setup it is working well and ready for phase 2.

Types of changes

Non-functional change (docs, style, minor refactor)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my code changes.
I added a changeset, or this is docs-only and I added an empty changeset.
All new and existing tests passed.
My code follows the code style of this project.

changeset-bot · 2026-06-07T08:15:54Z

🦋 Changeset detected

Latest commit: 61c30c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
nostream	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2026-06-08T15:22:21Z

coverage: 67.243% (+0.5%) from 66.747% — Ferryx349:ADMIN-CONSOLE-1 into cameri:main

Copilot

Pull request overview

This PR lays the groundwork for an (optionally enabled) admin backend by introducing an /admin API surface with password-based login, signed sessions, and a protected health endpoint, along with supporting settings and unit tests.

Changes:

Add a disabled-by-default /admin router with /login, /session, and /health endpoints.
Introduce password auth provider + signed session token utilities, plus admin-specific rate limiting.
Extend settings/types and defaults to configure admin enablement, session TTL, and admin rate limits; add unit tests and changeset.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/unit/utils/admin-session.spec.ts	Unit tests for session token creation/validation and request extraction.
test/unit/utils/admin-rate-limit.spec.ts	Unit tests for admin/login rate-limiting behavior.
test/unit/routes/admin.spec.ts	Router-level tests for disabled-by-default, login, and protected endpoints.
src/utils/admin-session.ts	Signed session token generation/validation + extraction from headers/cookies.
src/utils/admin-rate-limit.ts	Admin/login rate-limit helper using configured limits + IP whitelist.
src/utils/admin-password.ts	Password hashing/verification helpers (scrypt + timing-safe compare).
src/utils/admin-health.ts	Admin health snapshot collection (DB + Redis ping).
src/schemas/admin-login-schema.ts	Zod schema for admin login request body.
src/routes/index.ts	Mount `/admin` router into the main routing table.
src/routes/admin/index.ts	Admin router implementation: enabled-gate, login/session/health wiring.
src/handlers/request-handlers/admin-rate-limit-middleware.ts	Express middlewares for admin and login rate limiting.
src/factories/controllers/post-admin-login-controller-factory.ts	Factory wiring for login controller.
src/factories/controllers/get-admin-session-controller-factory.ts	Factory wiring for session controller.
src/factories/controllers/get-admin-health-controller-factory.ts	Factory wiring for health controller.
src/factories/admin-auth-provider-factory.ts	Factory for selecting/admin auth provider (currently password-based).
src/controllers/admin/post-login-controller.ts	Controller delegating login to auth provider.
src/controllers/admin/get-session-controller.ts	Controller returning session status/expiry.
src/controllers/admin/get-health-controller.ts	Controller returning admin health snapshot.
src/admin/password-admin-auth-provider.ts	Password auth provider: login + cookie issuance + request auth checks.
src/@types/settings.ts	Add `admin` settings and `limits.admin` typing.
src/@types/admin.ts	Define `IAdminAuthProvider` interface.
resources/default-settings.yaml	Add default admin settings and admin rate-limit defaults.
.changeset/admin-console-phase-1.md	Changeset entry for the new admin API foundation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Ferryx349 · 2026-06-18T07:29:33Z

I have squashed commits and force pushed to fix lint failures in CI getting due to wrong commit structure.

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

…mits

Ferryx349 · 2026-06-25T04:49:30Z

@cameri can u PTAL so we can proceed to our next phase, after merging this one..

Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

- Move admin enabled/auth checks into request-handlers middleware - Reuse admin auth provider instance per process - Deduplicate admin rate-limit middleware via scope factory - Return JSON errors from admin controller wrapper - Drop duplicated sessionTtlSeconds default from settings yaml Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Ferryx349 marked this pull request as draft June 7, 2026 08:18

github-advanced-securityBot found potential problems Jun 8, 2026
View reviewed changes

Comment threadsrc/routes/admin/index.ts Fixed
Comment threadsrc/routes/admin/index.ts Fixed

Ferryx349 force-pushed the ADMIN-CONSOLE-1 branch 2 times, most recently from 014b0c8 to 92516e3Compare June 12, 2026 08:19

github-advanced-securityBot found potential problems Jun 12, 2026
View reviewed changes

Comment threadsrc/routes/admin/index.ts Fixed
Comment threadsrc/routes/admin/index.ts Fixed

Ferryx349 marked this pull request as ready for review June 12, 2026 08:21

Ferryx349 requested review from cameri and Copilot June 16, 2026 04:09

Copilotstarted reviewing on behalf of Ferryx349 June 16, 2026 04:09 View session

CopilotAI reviewed Jun 16, 2026
View reviewed changes

Ferryx349 marked this pull request as draft June 16, 2026 18:03

Ferryx349 force-pushed the ADMIN-CONSOLE-1 branch from f455b7a to 01d3434Compare June 18, 2026 07:17

feat(admin): add backend foundation (login, session, health)
84d5f93

Ferryx349 force-pushed the ADMIN-CONSOLE-1 branch from 01d3434 to 84d5f93Compare June 18, 2026 07:27

Ferryx349 requested a review from Copilot June 18, 2026 07:29

Copilotstarted reviewing on behalf of Ferryx349 June 18, 2026 07:30 View session

CopilotAI reviewed Jun 18, 2026
View reviewed changes

Comment threadsrc/utils/admin-rate-limit.ts
Comment threadsrc/routes/admin/index.ts Outdated
Comment threadsrc/admin/password-admin-auth-provider.ts

fix(admin): handle missing SECRET and default ipWhitelist for rate li…
efcea03
…mits

Ferryx349 marked this pull request as ready for review June 18, 2026 08:20

Ferryx349 mentioned this pull request Jun 26, 2026
[Admin Console] : Add OpenTelemetry metrics foundation with Prometheus export #652
Closed

Ferryx349 force-pushed the ADMIN-CONSOLE-1 branch from 8c3573a to f4b052dCompare June 29, 2026 07:12

fix(admin): rate limit request before checking if admin is enabled
867b788
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

Ferryx349 force-pushed the ADMIN-CONSOLE-1 branch from f4b052d to 867b788Compare June 29, 2026 07:23

github-advanced-securityBot found potential problems Jun 29, 2026
View reviewed changes

Comment threadsrc/routes/admin/index.ts
Comment threadsrc/routes/admin/index.ts

Merge branch 'main' into ADMIN-CONSOLE-1
02d842a

This was referenced Jun 30, 2026
[Admin Console] : Add cluster-aware /admin/metrics SSE endpoint (Prometheus-backed) #655
Closed
feat(admin): add Prometheus-backed /admin/metrics SSE endpoint #662
Merged

Merge branch 'main' into ADMIN-CONSOLE-1
61c30c8

cameri approved these changes Jul 4, 2026
View reviewed changes

cameri merged commit 837540b into cameri:mainJul 4, 2026
16 of 18 checks passed

cameri mentioned this pull request Jul 4, 2026
chore: release new version 🚀 #658
Open

Ferryx349 added a commit to Ferryx349/nostream that referenced this pull request Jul 4, 2026
chore(admin): merge upstream main after ADMIN-CONSOLE-1 (cameri#641)
6503bef
Co-authored-by: Cursor <cursoragent@cursor.com>

Ferryx349 mentioned this pull request Jul 4, 2026
[Admin Console] Phase 1: Admin Backend Foundation #631
Closed

Ferryx349 deleted the ADMIN-CONSOLE-1 branch July 4, 2026 14:54

Justxd22 mentioned this pull request Jul 7, 2026
feat: Admin Console for relay operators #594
Open

Ferryx349 mentioned this pull request Jul 16, 2026
CodeQL false positive: js/missing-rate-limiting on admin routes with custom middleware #691
Open

Ferryx349 mentioned this pull request Aug 18, 2026
[REQUEST] log and visualize key performance parameters #144
Closed
9 tasks

Conversation

Ferryx349 commented Jun 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Screenshots

Types of changes

Checklist:

Uh oh!

changeset-botBot commented Jun 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jun 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ferryx349 commented Jun 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ferryx349 commented Jun 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ferryx349 commented Jun 7, 2026•
edited
Loading

changeset-botBot commented Jun 7, 2026•
edited
Loading

coveralls commented Jun 8, 2026•
edited
Loading

Ferryx349 commented Jun 18, 2026•
edited
Loading