feat(admin): add authenticated settings API endpoints by Ferryx349 · Pull Request #690 · cameri/nostream

Ferryx349 · 2026-07-16T06:09:22Z

Description

Adds backend-only admin settings endpoints that reuse the shared settings-config module from #672, so the admin console can read and update relay settings without duplicating CLI logic.

Why

The admin settings editor needs the same get/set/validate behavior as the CLI. This PR exposes that through authenticated admin routes ahead of the UI work in #594.

Related Issue

Fixes- Part of #665

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Non-functional change (docs, style, minor refactor)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my code changes.
I added a changeset, or this is docs-only and I added an empty changeset.
All new and existing tests passed.

Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

changeset-bot · 2026-07-16T06:09:27Z

🦋 Changeset detected

Latest commit: 733b79f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
nostream	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2026-07-16T06:14:40Z

coverage: 69.623% (+0.9%) from 68.718% — Ferryx349:settings-api into cameri:main

Reconcile merged UI-DASH and Settings PRs with the settings API branch: keep authenticated settings endpoints, adopt upstream dashboard, Grafana port 7777, fail-closed rate limiting, and Settings review refactors.

Copilot

Pull request overview

Adds authenticated admin API endpoints to read, validate, and update relay settings using the shared settings-config utilities (introduced in #672), including redaction of sensitive fields for safe UI consumption.

Changes:

Add /admin/settings read endpoint and /admin/settings/schema guided schema endpoint for the admin console.
Add /admin/settings/validate and /admin/settings (PATCH) endpoints to validate and persist settings updates.
Introduce settings redaction utilities and unit tests covering redaction and the new admin settings routes.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/unit/utils/settings-redaction.spec.ts	Adds unit coverage for sensitive-path detection and secret redaction behavior.
test/unit/routes/admin-settings.spec.ts	Adds integration-style unit tests for admin settings endpoints (auth, get/schema/validate/patch).
test/unit/app/maintenance-worker.spec.ts	Updates existing test to stub new metrics telemetry shutdown dependency.
src/utils/settings-redaction.ts	Implements redaction helpers for settings payloads and per-path values.
src/schemas/admin-settings-schema.ts	Adds request-body schema for admin settings PATCH validation.
src/routes/admin/index.ts	Registers new authenticated admin settings routes under the admin router.
src/factories/controllers/post-admin-settings-validate-controller-factory.ts	Wires up the settings validate controller.
src/factories/controllers/patch-admin-settings-controller-factory.ts	Wires up the settings patch controller.
src/factories/controllers/get-admin-settings-schema-controller-factory.ts	Wires up the guided settings schema controller.
src/factories/controllers/get-admin-settings-controller-factory.ts	Wires up the get settings controller.
src/controllers/admin/post-settings-validate-controller.ts	Implements merged-settings validation endpoint.
src/controllers/admin/patch-settings-controller.ts	Implements validated dot-path PATCH with persistence and response redaction.
src/controllers/admin/get-settings-schema-controller.ts	Exposes guided setting categories for the admin UI.
src/controllers/admin/get-settings-controller.ts	Exposes merged settings with secret redaction.
.changeset/admin-settings-api.md	Declares a minor release for the new admin settings API feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Implement atomic writes and timestamped backups in saveSettings - Fix array path validation for empty default schemas - Filter unknown keys from merged settings in GET /admin/settings to prevent secret leaks

Ferryx349 added 5 commits July 8, 2026 11:57

feat(admin): extract shared settings-config module for CLI and admin UI
8608b26
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

fix(settings-config): harden path parsing against prototype pollution
89f09b9
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

Merge branch 'main' into Settings
1e3e8b7

Merge branch 'main' into Settings
4f261ab

feat(admin): add authenticated settings API endpoints
cc5c7b3
Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

github-advanced-securityBot found potential problems Jul 16, 2026
View reviewed changes

Comment threadsrc/routes/admin/index.ts
Comment threadsrc/routes/admin/index.ts
Comment threadsrc/routes/admin/index.ts
Comment threadsrc/routes/admin/index.ts

This was referenced Jul 16, 2026
CodeQL false positive: js/missing-rate-limiting on admin routes with custom middleware #691
Open
feat: Admin Console for relay operators #594
Open

Ferryx349and others added 3 commits July 20, 2026 10:07

Merge upstream/main into settings-API
3878d55
Reconcile merged UI-DASH and Settings PRs with the settings API branch: keep authenticated settings endpoints, adopt upstream dashboard, Grafana port 7777, fail-closed rate limiting, and Settings review refactors.

ci: retrigger checks
e7c0e78

Merge branch 'main' into settings-api
0447dcd

Ferryx349 mentioned this pull request Jul 22, 2026
feat(admin): add settings editor tab to admin dashboard #706
Merged
18 tasks

Merge branch 'main' into settings-api
d2b424c

cameri requested a review from Copilot July 27, 2026 12:25

Copilotstarted reviewing on behalf of cameri July 27, 2026 12:25 View session

cameri approved these changes Jul 27, 2026
View reviewed changes

CopilotAI reviewed Jul 27, 2026
View reviewed changes

Comment threadsrc/controllers/admin/patch-settings-controller.ts
Comment threadsrc/controllers/admin/patch-settings-controller.ts
Comment threadsrc/controllers/admin/get-settings-controller.ts

fix(admin): improve settings persistence and validation
733b79f
- Implement atomic writes and timestamped backups in saveSettings - Fix array path validation for empty default schemas - Filter unknown keys from merged settings in GET /admin/settings to prevent secret leaks

cameri approved these changes Jul 27, 2026
View reviewed changes

cameri merged commit f70adf2 into cameri:mainJul 27, 2026
17 of 18 checks passed

cameri mentioned this pull request Jul 27, 2026
chore: release new version 🚀 #658
Open

Ferryx349 mentioned this pull request Jul 27, 2026
[Admin Console] Phase 3: Visual Settings Editor #633
Closed

Ferryx349 mentioned this pull request Aug 18, 2026
[REQUEST] log and visualize key performance parameters #144
Closed
9 tasks

Navigation Menu

feat(admin): add authenticated settings API endpoints - #690

feat(admin): add authenticated settings API endpoints#690
cameri merged 10 commits into
cameri:mainfrom
Ferryx349:settings-api

Ferryx349 commented Jul 16, 2026

Uh oh!

changeset-botBot commented Jul 16, 2026•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jul 16, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Ferryx349 commented Jul 16, 2026

Description

Why

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

changeset-botBot commented Jul 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jul 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-botBot commented Jul 16, 2026•
edited
Loading

coveralls commented Jul 16, 2026•
edited
Loading