feat(nip66): add RelayMonitorWorker cluster worker and probe scheduler by Ferryx349 · Pull Request #724 · cameri/nostream

Ferryx349 · 2026-08-10T15:13:12Z

Description

This PR:-

Adds WORKER_TYPE=relay-monitor cluster worker that schedules NIP-66 probes on nip66.probeIntervalSeconds
Probes configured nip66.targets, or falls back to info.relay_url
Persists the latest probe snapshot in Redis for downstream admin API (feat(admin): add GET /admin/network-health endpoint #697) and event publishing (feat(nip66): publish kind 30166 and 10166 relay health events #696)
Forks the worker from the primary process when nip66.enabled is true

Related Issue

Closes#695

Motivation and Context

How Has This Been Tested?

Set nip66.enabled: true in settings and confirm 1 relay-monitor worker started in logs
Confirm Redis key nip66:snapshot:latest is populated after probe interval
Set nip66.enabled: false and confirm no relay-monitor worker is forked
Configure custom nip66.targets and verify those URLs are probed

Screenshots (if appropriate):

Types of changes

Non-functional change (docs, style, minor refactor)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my code changes.
I added a changeset, or this is docs-only and I added an empty changeset.
All new and existing tests passed.

changeset-bot · 2026-08-10T15:13:21Z

🦋 Changeset detected

Latest commit: 8466288

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
nostream	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coveralls · 2026-08-10T15:18:53Z

coverage: 70.013% (+0.07%) from 69.944% — nip66_worker into main

Copilot

Pull request overview

Adds the NIP-66 relay monitoring foundation to Nostream by introducing a dedicated relay-monitor cluster worker that schedules periodic relay probes, persists the latest probe snapshot to Redis, and wires new nip66.* settings into defaults and documentation.

Changes:

Add WORKER_TYPE=relay-monitor cluster worker (RelayMonitorWorker) that schedules and runs NIP-66 probes and stores the latest snapshot in Redis.
Introduce a shared relay probe engine (DNS/TLS/WS RTT/NIP-11) plus target resolution and snapshot storage utilities.
Add nip66.* settings types, defaults, documentation, and unit tests covering settings/targets/probing/snapshot persistence.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/unit/utils/settings.spec.ts	Adds unit coverage for `nip66.*` default-settings and merge behavior.
test/unit/utils/relay-probe-targets.spec.ts	Tests probe target resolution and validation/filtering.
test/unit/utils/relay-probe-target.spec.ts	Tests probe target parsing, network type detection, and safety helpers.
test/unit/utils/relay-probe-snapshot.spec.ts	Tests Redis snapshot store read/write and status derivation.
test/unit/utils/relay-probe-run.spec.ts	Tests end-to-end probe runner behavior (timeouts, cache, error surfacing).
test/unit/utils/relay-probe-dns.spec.ts	Tests DNS record collection behavior.
test/unit/app/relay-monitor-worker.spec.ts	Tests scheduler behavior, overlap-skipping, interval minimum, and shutdown handling.
src/utils/relay-probe/ws-rtt-probe.ts	Implements WS handshake RTT probing via `ws`.
src/utils/relay-probe/types.ts	Adds probe engine types and defaults (timeouts, DNS cache TTL).
src/utils/relay-probe/tls-probe.ts	Implements TLS certificate probing via `tls.connect`.
src/utils/relay-probe/target.ts	Adds relay URL parsing and network-type helpers (clearnet/tor/i2p).
src/utils/relay-probe/run-probe.ts	Implements the orchestrated probe run across DNS/TLS/WS/NIP-11.
src/utils/relay-probe/nip11-probe.ts	Implements NIP-11 fetching with redirect/SSRF safeguards and schema parsing.
src/utils/relay-probe/index.ts	Exposes the probe engine public API surface.
src/utils/relay-probe/dns-probe.ts	Implements DNS resolution with A/AAAA/CNAME collection and error handling.
src/utils/relay-probe/dns-cache.ts	Adds in-memory DNS cache with TTL support.
src/utils/relay-probe-targets.ts	Adds settings-driven probe target selection and validation helpers.
src/utils/relay-probe-snapshot.ts	Adds Redis snapshot storage and run status derivation.
src/index.ts	Registers `relay-monitor` in worker runner selection.
src/factories/relay-monitor-worker-factory.ts	Wires `RelayMonitorWorker` with Redis-backed snapshot store and settings.
src/app/relay-monitor-worker.ts	Adds the `relay-monitor` scheduler worker implementation.
src/app/app.ts	Forks the `relay-monitor` worker when `nip66.enabled` is true.
src/@types/settings.ts	Adds `Nip66Settings` to the Settings model.
src/@types/relay-probe-snapshot.ts	Adds typed snapshot contract used for Redis persistence/downstream APIs.
resources/default-settings.yaml	Adds `nip66` configuration block with defaults.
CONFIGURATION.md	Documents `nip66.*` settings in the configuration reference.
.knip.json	Updates knip ignore list to account for new probe module usage patterns.
.env.example	Adds reserved monitor identity env var example.
.changeset/nip66-settings-foundation.md	Changeset entry for settings foundation.
.changeset/nip66-relay-monitor-worker.md	Changeset entry for the new worker/scheduler.
.changeset/nip66-probe-engine.md	Changeset entry for the shared probe engine.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Add WORKER_TYPE=relay-monitor to schedule NIP-66 probes on a configurable interval, persist the latest snapshot in Redis, and fork the worker when nip66.enabled is true.

Reject unbracketed IPv6 hostnames in isNip11FetchTargetSafe and introduce StoredProbeResult so Redis snapshots accurately use ISO date strings.

Ferryx349 · 2026-08-13T14:23:45Z

I have rebased this branch, ready to review now.

cameri · 2026-08-16T16:49:50Z


- if (host.startsWith('[') && host.endsWith(']')) {
+ // IPv6 literal: URL.hostname is unbracketed (e.g. "::1"); NIP-11 fetch targets should not be IP literals.
+ if (host.includes(':')) {


Not sure if this is correct for IPv6. Doesn't zod have something for this? If not okay we can leave as-is.

Zod doesn’t have a built-in for this in our stack. Happy to switch to net.isIP() in a follow-up.

cameri · 2026-08-18T02:12:08Z

thank you @Ferryx349 !

Ferryx349 requested a lite review from Copilot August 10, 2026 15:19

Copilotstarted reviewing on behalf of Ferryx349 August 10, 2026 15:20 View session

CopilotAI reviewed Aug 10, 2026
View reviewed changes

Comment threadsrc/utils/relay-probe/nip11-probe.ts Outdated
Comment threadsrc/@types/relay-probe-snapshot.ts

Ferryx349 added 2 commits August 13, 2026 09:59

feat(nip66): add RelayMonitorWorker cluster worker and probe scheduler
e538614
Add WORKER_TYPE=relay-monitor to schedule NIP-66 probes on a configurable interval, persist the latest snapshot in Redis, and fork the worker when nip66.enabled is true.

fix(nip66): block IPv6 NIP-11 targets and type stored probe snapshots
9a01d3d
Reject unbracketed IPv6 hostnames in isNip11FetchTargetSafe and introduce StoredProbeResult so Redis snapshots accurately use ISO date strings.

Ferryx349 force-pushed the nip66_worker branch from e169ddf to 9a01d3dCompare August 13, 2026 04:30

Merge branch 'main' into nip66_worker
7730154

Merge branch 'main' into nip66_worker
8466288

cameri reviewed Aug 16, 2026
View reviewed changes

cameri approved these changes Aug 16, 2026
View reviewed changes

Ferryx349 merged commit d14b1e9 into mainAug 16, 2026
18 of 19 checks passed

Ferryx349 deleted the nip66_worker branch August 16, 2026 17:09

cameri mentioned this pull request Aug 16, 2026
chore: release new version 🚀 #658
Open

Ferryx349 mentioned this pull request Aug 17, 2026
test(nip66): add integration tests for RelayMonitorWorker #733
Merged
11 tasks

Navigation Menu

feat(nip66): add RelayMonitorWorker cluster worker and probe scheduler - #724

feat(nip66): add RelayMonitorWorker cluster worker and probe scheduler#724
Ferryx349 merged 4 commits into
mainfrom
nip66_worker

Ferryx349 commented Aug 10, 2026•
edited
Loading

Uh oh!

changeset-botBot commented Aug 10, 2026•
edited
Loading

Uh oh!

coveralls commented Aug 10, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Ferryx349 commented Aug 13, 2026

Uh oh!

cameriAug 16, 2026

Uh oh!

Ferryx349Aug 16, 2026

Uh oh!

Uh oh!

cameri commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Ferryx349 commented Aug 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

changeset-botBot commented Aug 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coveralls commented Aug 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Ferryx349 commented Aug 13, 2026

Uh oh!

cameriAug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Ferryx349Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cameri commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ferryx349 commented Aug 10, 2026•
edited
Loading

changeset-botBot commented Aug 10, 2026•
edited
Loading

coveralls commented Aug 10, 2026•
edited
Loading