Skip to content

fix: include event id in expired and rate-limited rejection logs#735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameri merged 3 commits into from
Aug 22, 2026
+10 −2
Merged

fix: include event id in expired and rate-limited rejection logs #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
654c977
fix: include event id in expired and rate-limited rejection logs
Ferryx349 Aug 19, 2026
4827093
Merge branch 'main' into fix/723-rejection-logger-event-id
Priyanshubhartistm Aug 20, 2026
75feb35
Merge branch 'main' into fix/723-rejection-logger-event-id
Anshumancanrock Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/fix-rejection-logger-event-id.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
---
"nostream": patch
---

fix: include event id in expired and rate-limited rejection logs

Expired and rate-limited event rejections logged `event %s rejected: ...` without
passing `event.id`, so operators saw a literal `%s` instead of the event id.
4 changes: 2 additions & 2 deletions src/handlers/event-message-handler.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -69,15 +69,15 @@ export class EventMessageHandler implements IMessageHandler {
}

if (isExpiredEvent(event)) {
logger('event %s rejected: expired')
logger('event %s rejected: expired', event.id)
this.webSocket.emit(WebSocketAdapterEvent.Message, createEventCommandResult(event.id, false, 'event is expired'))
return
}

event = this.addExpirationMetadata(event)

if (await this.isRateLimited(event)) {
logger('event %s rejected: rate-limited')
logger('event %s rejected: rate-limited', event.id)
this.webSocket.emit(
WebSocketAdapterEvent.Message,
createEventCommandResult(event.id, false, 'rate-limited: slow down'),
Expand Down
Loading