fix(cli): stop info command from hanging when database is unreachable - #740
Open
Priyanshubhartistm wants to merge 1 commit into
Open
fix(cli): stop info command from hanging when database is unreachable#740Priyanshubhartistm wants to merge 1 commit into
Priyanshubhartistm wants to merge 1 commit into
Conversation
Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
🦋 Changeset detectedLatest commit: 02d92eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
coveralls
commented
Aug 23, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getEventCount()insrc/cli/commands/info.tsopened aknexconnection pool for a single ad-hoc query. When the initial connection attempt itself failed or timed out, the pool'sdestroy()resolved without actually closing the underlying socket, leaving an open handle behind and keeping the Node process alive indefinitely.Replaces the
knexpool with a rawpg.Client(connect()/query()/end()), which reliably closes its socket even when the connection attempt itself fails.Related Issue
Closes#739.
Motivation and Context
nostream info(andnostream info --json) would hang forever with no error or timeout if the configured database was unreachable, instead of failing cleanly like every other CLI command.