Ignore whitespace in diffs automatically

[riophae]

How about adding ?w=1 to any diff URLs automatically as optional? Personally speaking it's pretty useful, as I hardly ever care about any changes only in whitespace.

[camsong]

Thanks for pointing out such an useful trick 👏 , I'm sure it will help a lot of people.
In order not to confuse people who has got used to the current diff content, maybe we can add a button to enable this magic like this:

if you got a getter idea, glad to change.

[camsong]

A diff which may confuse people with this trick without a hint
https://github.com/angular/angular.js/pull/10539/files?w=1

[riophae]

Well done! 👍 Blazing fast!
Yes, indeed. In specific cases it would be very confusing.

I just came up with an alternative approach worth considering.

1. A checkbox in option page setting up whether ?w=1 will be added to any diff links automatically. The checkbox is unchecked as default, as users should be clear about the function before it being enabled.
2. Turn on the function manually. (In my opinion,) it would be without any problems in most cases.
3. With this trick, very rarely and unfortunately, the situation that no changes couldn't be shown is possible. And there is not a hint, which causes confusion. Okay. How about appending a hint into the page, leading user to the normal diff page?
4. Even more advanced (and radically), user could be redirected to the page without ?w=1 automatically, then we can show a hint that why whitespace hiding is disabled.
5. However, automatical redirecting is VERY RISKY. Please avoid of using it as far as possible.

May be a bit opinionated... or just all my fantasy :D
Thx for your patience!

[mattsfrey]

Is there any consideration for this still? Having an option to default PR's to not showing whitespace diffs would be extremely useful, especially for those of us writing clojure and aligning maps values, as an example. We get diffs that are often 50% or more just whitespace and have been having to manually append the ?w=1 to our PR URLS.

[camsong]

Prepare to add this but don't get a time, PR is welcomed.

[camsong]

Finally this feature comes out. Will toggle between Show Spaces and Ignore Spaces like

[riophae]

Seems it's not applied to commit details page? I didn't see a "Ignore Spaces" button there.

[camsong]

Released v0.16.3 to fix this

[amit133]

I am not able to see this feature

Check amit133/KTAB@0dbcf5a#diff-e4cd2a6be7b63a3b123aa8476c2456d1

[ArtS]

Is this ever going to be available in Pull Requests?

[camsong]

@ArtS @amit133 fixed in v0.16.5

[roboweaver]

The w=1 trick is nice for viewing diffs, unfortunately you can't add comments for the Pull Request which is where this would be most useful.

Really annoying to not be able to see your actual change in a file that accidentally (or intentionally) got formatted as part of a commit, since changing the whitespace doesn't matter in most languages.