Skip to content

Add skip_bmc_config parameter to create_machine to skip re-config of BMC - #294

Open
acormier1 wants to merge 1 commit into
canonical:masterfrom
acormier1:add_skip_bmc_config
Open

Add skip_bmc_config parameter to create_machine to skip re-config of BMC#294
acormier1 wants to merge 1 commit into
canonical:masterfrom
acormier1:add_skip_bmc_config

Conversation

@acormier1

@acormier1acormier1 commented Oct 16, 2023

Copy link
Copy Markdown

The create_machine API in Maas supports a skip_bmc_config flag. When set to true, this flag skips the bmc config so that a new user is not created. This is a workaround for some lenovo BMC's which have an issue during this provisioning step.

The result in maas when providing this parameter:
Screen Shot 2023-10-16 at 5 49 22 PM

@skyecasskyecas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look alright, though the MAAS API docs do suggest this parameter is an integer rather than a boolean https://git.launchpad.net/maas/tree/src/maasserver/api/machines.py#n2039, so we may need to do some testing

This parameter is also passable to the commissioning stage of a Machine, extending to include that may be useful.

@skyecas
skyecasforce-pushed the add_skip_bmc_config branch from fcfbbd0 to b29f064CompareMarch 18, 2024 18:34
@codecov-commenter

codecov-commenter commented Mar 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.43%. Comparing base (bfe63cc) to head (b29f064).

FilesPatch %Lines
maas/client/viscera/machines.py50.00%0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## master #294 +/- ##
==========================================
- Coverage 69.43% 69.43% -0.01% 
==========================================
Files 76 76 Lines 6024 6026 +2 Branches 1347 1348 +1 ==========================================
+ Hits 4183 4184 +1 
Misses 1612 1612 - Partials 229 230 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skyecas

Copy link
Copy Markdown
Contributor

Linter isn't happy, could you run tox -e format to fix that?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@acormier1@codecov-commenter@skyecas