Prevent blatent unsafety with extra_mut - #4
Merged
Conversation
emberian
commented
May 22, 2015
ContributorAuthor
(Pushing a new version to crates.io would be much appreciated, as the mutable_transmutes lint prevents this from building) |
This API allowed to *easily* alias multiple `&mut [u8]`, which wreaks havoc on alias analysis and causes llvm-level UB.
carllerche
commented
May 22, 2015
Owner
Yeah, this is definitely a blunder on my part. I will try to get this merged asap. I'm currently traveling, so hopefully tonight! |
emberian
commented
May 25, 2015
ContributorAuthor
@carllerche bump |
carllerche
commented
May 27, 2015
Owner
There was no internet where I was. Going to try to catch up on things now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API allowed to easily alias multiple
&mut [u8], which wreaks havoc onalias analysis and causes llvm-level UB.