Disposal

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Low Risk
No production logic changes beyond documentation and removal of dead code; risk is limited to test assertion fixes and new validation coverage.

Overview
Cleans up DisposalRate without changing the disposal algorithm: drops an unused warnings import, fixes fit_transform docs that incorrectly referenced VotingChainladder, and removes a stray _test helper.

Disposal tests now compare expected values with abs(...) so sign flips do not hide failures, and a new test_disposal_no_weight checks that fit and transform raise ValueError when sample_weight is omitted (including on a sparse triangle).

^{Reviewed by Cursor Bugbot for commit 252878e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (40f977f) to head (252878e).
⚠️ Report is 17 commits behind head on disposal_rate_method.

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1023 +/- ##
========================================================
+ Coverage 89.09% 89.22% +0.12% 
========================================================
Files 91 91 Lines 5228 5226 -2 Branches 666 666 ========================================================
+ Hits 4658 4663 +5 + Misses 400 396 -4 + Partials 170 167 -3 

Flag	Coverage Δ
unittests	89.22% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.