restructuring disposal attributes into mixin class by henrydingliu · Pull Request #1058 · casact/chainladder-python

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

henrydingliu · 2026-06-27T19:05:44Z

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Touches core Triangle inheritance and disposal transform math (incr_disposal_ is now computed lazily); behavior should match but rounding/flag handling paths changed.

Overview
Disposal rate state (disposal_ / incr_disposal_) moves into a shared DisposalMixin: cumulative disposal is stored on _disposal_, with getters/setters that enforce is_cumulative / is_pattern and derive incremental disposal from cumulative via cum_to_incr().

DisposalRate now subclasses the mixin; fit writes the fitted pattern straight to _disposal_ instead of manually toggling flags and building incr_disposal_. transform still assigns disposal_ on the output triangle but no longer copies incr_disposal_—downstream code uses the mixin property on Triangle ( TriangleBase also mixes in DisposalMixin).

The Friedland fidelity test splits fit / transform and rounds disposal_ through the property setter before transforming with rounded ultimates.

^{Reviewed by Cursor Bugbot for commit 74655d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

cursor · 2026-06-27T19:06:46Z

- self.incr_disposal_.is_pattern = True
- self.disposal_.is_pattern = True
+ disposal = self._param_property(self.disposal_rate_tri,self.params_.slope_[...,0][..., None, :])
+ self._disposal_ = concat((disposal,(self.X_.latest_diagonal*0 + 1).iloc[:,:,0,:].rename("development", [9999])),axis=3)


Fit bypasses disposal setter flags
Medium Severity
DisposalRate.fit writes _disposal_ directly instead of using the disposal_ setter, so fitted disposal data keeps is_cumulative=False from _param_property. The mixin’s incr_disposal_ then skips cum_to_incr, and disposal_/incr_disposal_ on the estimator after fit() no longer match the old cumulative semantics.
^{Reviewed by Cursor Bugbot for commit 74655d1. Configure here.}

codecov · 2026-06-27T19:09:54Z

Codecov Report

❌ Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.25%. Comparing base (df8e2f9) to head (74655d1).
⚠️ Report is 37 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	66.66%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1058 +/- ##
========================================================
- Coverage 89.31% 89.25% -0.07% 
========================================================
Files 91 91 Lines 5234 5275 +41 Branches 666 671 +5 ========================================================
+ Hits 4675 4708 +33 - Misses 391 401 +10 + Partials 168 166 -2

Flag	Coverage Δ
unittests	`89.25% <67.64%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

restructuring disposal attributes into mixin class
74655d1

henrydingliu requested review from genedan, jbogaardt and kennethshsu as code owners June 27, 2026 19:05

henrydingliu merged commit f21954c into casact:disposal_rate_methodJun 27, 2026
8 of 9 checks passed