adding is_disposal_rate attribute to triangle

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming disposal_/incr_disposal_ is a breaking API change, and changes to incr_to_cum/cum_to_incr for disposal patterns affect core reserving math paths.

Overview
Introduces is_disposal_rate on Triangle and a disposal_rate_tri property (cumulative paid/incurred over ultimate_, flagged as a disposal pattern). incr_to_cum / cum_to_incr now skip multiplicative link-ratio handling when is_disposal_rate is set, so disposal patterns use ordinary cumulative differencing instead.

DisposalRate renames fitted pattern attributes from disposal_ / incr_disposal_ to disposal_rate_ / incr_disposal_rate_, sets is_disposal_rate on stored patterns, and derives weights and transforms via X_.disposal_rate_tri after attaching ultimate_ on the training triangle rather than keeping a separate disposal_rate_tri on the estimator. Tests follow the new names and assert AttributeError when disposal_rate_ is accessed before fit.

^{Reviewed by Cursor Bugbot for commit 6487299. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (74655d1) to head (6487299).
⚠️ Report is 38 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	78.57%	6 Missing ⚠️
chainladder/core/triangle.py	85.18%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1066 +/- ##
========================================================
+ Coverage 89.25% 89.33% +0.08% 
========================================================
Files 91 91 Lines 5275 5288 +13 Branches 671 672 +1 ========================================================
+ Hits 4708 4724 +16 + Misses 401 399 -2 + Partials 166 165 -1 

Flag	Coverage Δ
unittests	89.33% <81.81%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.