improving docstring and adding codecov coverage

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
Renaming and re-plumbing disposal weights touches core reserving paths (disposal_rate_tri, fit/transform); behavior should stay equivalent but any external code that relied on w_ on disposal triangles would break.

Overview
Disposal-rate estimation and triangles now use disposal_w_ instead of w_ for TriangleWeight results, including DisposalRate.fit, transform (weights copied onto the output triangle), and disposal_rate_tri masking. That avoids colliding with development w_ while keeping the same weighting behavior.

DisposalMixin gains short docstrings on disposal_rate_ / incr_disposal_rate_ getters and setters. Docs for disposal_rate_tri are updated to match the new weighted output (e.g. 12-Ult column labels). A test test_setting_incr asserts scaling incr_disposal_rate_ doubles disposal_rate_.

^{Reviewed by Cursor Bugbot for commit 432158d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.48%. Comparing base (6487299) to head (432158d).
⚠️ Report is 39 commits behind head on disposal_rate_method.

Files with missing lines	Patch %	Lines
chainladder/adjustments/disposal.py	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## disposal_rate_method #1068 +/- ##
========================================================
+ Coverage 89.33% 89.48% +0.15% 
========================================================
Files 91 91 Lines 5288 5288 Branches 672 672 ========================================================
+ Hits 4724 4732 +8 + Misses 399 392 -7 + Partials 165 164 -1 

Flag	Coverage Δ
unittests	89.48% <71.42%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.