Uh oh!
There was an error while loading. Please reload this page.
docs: add cdf_/ibnr_/pipe/set_backend examples (#704) - #1212
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 0.0% fully typed (0 / 1)
Patch symbol details
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1212 +/- ##
=======================================
Coverage 91.31% 91.32% =======================================
Files 91 92 +1 Lines 5434 5438 +4 Branches 700 700 =======================================
+ Hits 4962 4966 +4
Misses 336 336 Partials 136 136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
commented
Aug 13, 2026
for pct_reported_ should be added to the attribute list in good with the rest. |
…_ on Development. These stay estimator attributes until ldf_/ultimate_ are properties too, so they are no longer un-excluded on the Triangle autosummary page. Co-authored-by: Cursor <cursoragent@cursor.com>
EKtheSage
commented
Aug 13, 2026
|
henrydingliu
commented
Aug 13, 2026
ruff fix pretty pls? |
kennethshsu
commented
Aug 13, 2026
@EKtheSage you may need to do a uv sync to get the ruff stuff in |
…template. Clearing per-file ignores on triangle.py and common.py surfaced E721/E731/E712/F401/F841. The template unions documented attrs and arithmetic dunders so sibling casact#704 PRs merge without wiping each other. Co-authored-by: Cursor <cursoragent@cursor.com>
… autosummary template. The ruff workflow lints touched files with per-file ignores cleared. The template now unions the documented Triangle attrs and arithmetic dunders so casact#1208, casact#1212, and casact#1213 do not clobber each other on merge. Co-authored-by: Cursor <cursoragent@cursor.com>
EKtheSage
commented
Aug 14, 2026
Ruff: the workflow clears per-file ignores on touched files, so The autosummary template is the same union as #1208/#1211/#1213 (indexers, shape attrs, arithmetic dunders). |
The last merge of casact#1208/casact#1211/casact#1212/casact#1213 would otherwise wipe documented indexers, shape attrs, or arithmetic dunders. Co-authored-by: Cursor <cursoragent@cursor.com>
The pipe() doctest now normalizes whitespace so pandas header padding does not fail CI. Co-authored-by: Cursor <cursoragent@cursor.com>
EKtheSage
commented
Aug 14, 2026
Merged The failing Triangle |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit daf006a. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
* docs: add Triangle shape/empty/compute doctest examples (#704) Co-authored-by: Cursor <cursoragent@cursor.com> * Tighten TriangleBase examples from review on nan_triangle, get_array_module, and compute. Print the nan mask as-is, show numpy/sparse module identity, and document compute with a dask code sample instead of a numpy no-op doctest. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix E721 in TriangleBase, show a fake compute() output, and align the autosummary template. The ruff workflow lints touched files with per-file ignores cleared. The template now unions the documented Triangle attrs and arithmetic dunders so #1208, #1212, and #1213 do not clobber each other on merge. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
henrydingliu
commented
Aug 14, 2026
@EKtheSage thanks for all the work! FYI there's a cursor warning and a conflict |
num_to_value mutates zeros in place; the F841 cleanup dropped that write and left adjacent-age division seeing raw zeros. Co-authored-by: Cursor <cursoragent@cursor.com>
…mples Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # pyproject.toml
… regression test that pattern cum_to_incr stays finite when CDF cells are zero. Co-authored-by: Cursor <cursoragent@cursor.com>
The Cursor warning was a real side-effect of the F841 cleanup: num_to_value(self.values, 1) mutates zeros to ones before pattern cum_to_incr divides adjacent ages. That call is restored, with a regression test that a zero CDF cell stays finite. Conflict: merged upstream/main into this branch (not into casact main). |
henrydingliu
left a comment
There was a problem hiding this comment.
new test doesn't need to be its own file but harmless as is
Uh oh!
There was an error while loading. Please reload this page.

Summary of Changes
Examplesforcdf_,pct_reported_,ibnr_, andset_backendinchainladder/core/common.py.pipeexample from>>>doctest style totestsetup/testcode/testoutput.cdf_/ibnr_/pct_reported_from the class autosummary templates so the examples appear on estimator and Triangle API pages.Related GitHub Issue(s)
Additional Context for Reviewers
Bite-sized core-module follow-up for #704. Companions: #1208 (slice), #1209 (io), #1210 (display).
Checklist
Made with Cursor