Skip to content

Fix details in message.json - #141

Merged
kchason merged 2 commits into
masterfrom
BugFix-CASE-Mapping-Python-Pull-38
Apr 25, 2024
Merged

Fix details in message.json#141
kchason merged 2 commits into
masterfrom
BugFix-CASE-Mapping-Python-Pull-38

Conversation

@ajnelson-nist

Copy link
Copy Markdown
Member

Reported in CASE-Mapping-Python PR 38.
No effects were observed on Make-managed files.
References:
* casework/CASE-Mapping-Python#38
Reported-by: Fabrizio Turchi <fabrizio.turchi@cnr.it>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
`uco-observable:displayName` is not associated with
`uco-observable:MessageThreadFacet` by a SHACL property shape, at the
time of UCO 1.3.0.
Nothing encoded in UCO disallows the way it was used in `message.json`,
but the data stored in that property is being removed to follow the
suggestions from the SHACL shapes.
Reported in CASE-Mapping-Python PR 38.
No effects were observed on Make-managed files.
References:
* casework/CASE-Mapping-Python#38
Reported-by: Fabrizio Turchi <fabrizio.turchi@cnr.it>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist

Copy link
Copy Markdown
MemberAuthor

This should be reviewed and merged by someone else once CI has passed.

Each Git commit has a log message describing the change rationale.

@ajnelson-nist
ajnelson-nist marked this pull request as ready for review March 13, 2024 19:17
@ajnelson-nist
ajnelson-nist requested a review from a teamMarch 13, 2024 19:17
@ajnelson-nist

Copy link
Copy Markdown
MemberAuthor

On checking again,displayName is not currently associated with MessageThreadFacet. Hence the suggestion from @fabrizio-turchi is implemented in this PR.

@kchason
kchason merged commit 6d81e3c into masterApr 25, 2024
@kchason
kchason deleted the BugFix-CASE-Mapping-Python-Pull-38 branch April 25, 2024 14:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ajnelson-nist@kchason