Uh oh!
There was an error while loading. Please reload this page.
Add SPARQL query result type assertions - #102
Merged
Merged
Conversation
RDFLib 6.3.0, released today, included an update to type hints for the `Graph.query` function. Issue 2283 logs some of the new induced type hints required to get `mypy --strict` to pass. This patch is needed to respond to the newly induced type assertion requirements. It is intentionally based off of `main` in case a hotfix `case-utils` release is required. References: * RDFLib/rdflib#2283 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This patch is built off of `main` due to one of the `pre-commit` environments failing in its current pinned version, meaning this could potentially be part of a bugfix release. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
commented
Mar 17, 2023
MemberAuthor
Once CI passes, I'm fine with this being merged. But, CI must pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intentionally filed with a patch based on
main. In anticipation of acase-utilsrelease in the next two weeks, and for lack of recollection of downstream module importers ofcase_utils.case_sparql_select(and_construct), there might not be need of a0.9.1release to cover a two-week gap.