Skip to content

Release 0.12.0 - #125

Merged
kchason merged 43 commits into
mainfrom
release-0.12.0
Aug 25, 2023
Merged

Release 0.12.0#125
kchason merged 43 commits into
mainfrom
release-0.12.0

Conversation

@ajnelson-nist

@ajnelson-nistajnelson-nist commented Aug 25, 2023

Copy link
Copy Markdown
Member

Coordination

  • CI passes

ajnelson-nistand others added 30 commits September 16, 2022 13:45
References:
* RDFLib/pySHACL#89
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
I stumbled across this being a potential point of confusion in the
Exifread mapping repository's PR 21.
References:
* casework/CASE-Implementation-PyPI-Exifread#21
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This sets `case-utils` and downstream Python tooling to take care in
reviewing new RDFLib releases for breaking changes. RDFLib Issue 2402
and Discussion 2395 outline an upcoming development period for RDFLib
that may see more frequent SEMVER-major version releases.
References:
* RDFLib/rdflib#2402
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
…_ceilings
Start specifying RDFLib version ceilings
This patch partially implements a small piece of PR 118.
References:
* #118
Requested-by: kchason <keith.chason@gmail.com>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
AJN: This is a partial application of @kchason 's work in PR 118, and is
being pulled into its own patch series to focus review.
References:
* #118
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
As spelled before this patch, the doctests were running after the more
time-consuming `case_utils` descent. This lets the tests be called on
their own, and also lets a failing doctest fail the CI job quicker.
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
No effects were observed on Make-managed files.
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
It seems to me like `--disallow-untyped-defs`, enabled in
`mypy --strict`, should have flagged this as an error. However, from
documentation on `no-untyped-def`, `mypy` only requires
`__init__(...) -> None` when there is any argument aside from the first
`self`. This patch follows the parenthetical recommendation from PEP
484 that `-> None` be given anyways.
References:
* https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-disallow-untyped-defs
* https://mypy.readthedocs.io/en/stable/error_code_list2.html#check-that-every-function-has-an-annotation-no-untyped-def
* https://peps.python.org/pep-0484/#the-meaning-of-annotations
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
… type
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Defaulting to the string `"none"` has a functional consequence in
downstream pySHACL operations, as encoded at the time of this writing
(pySHACL version 0.23.0). `inference` in the `pyshacl.validate(...)`
arguments is propagated down two code paths that both impact the
validation operation, but that use different default values. The
`--metashacl` (SHACL-SHACL validation graph for reviewing shape syntax)-
aligned code path defaults to `rdfs` inference, and the `Validator`
class defaults to the string `"none"`.
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
…do_concepts
case_validate: Expose CDO IRI typo-checker as function
Move doctests checking to own target in preorder traversal
…default
case_validate: Default inference flag to None rather than "none"
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nistand others added 13 commits August 23, 2023 10:22
…n "none"
This is a continuation of PR 123.
References:
* #123
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
…idate
This patch separates implementation points between functionality
distinct to `case_utils.validate` and `pyshacl.validate`. The
`allow_warnings` and `inference` parameters provide CASE-specific
documentation as an augmentation to `pyshacl.validate`'s documentation,
but otherwise other documentation on `pyshacl.validate`'s keyword
arguments is delegated to their upstream function.
This patch removes some hardcoded parameter values in
`pyshacl.validate`, letting the `case_validate` CLI or caller provide
any runtime-requested values.
Also, without functional impact, this patch sorts keyword parameters
alphabetically.
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This is part of addressing what originally inspired pySHACL Issue 170.
This patch modifies the behavior of `case_validate`, that reviews OWL
syntax and OWL-SHACL interactions. With this patch, that functionality
is now **opt-in** at call time.
Further work on separating the OWL review shapes from UCO into a general
CDO repository (originally started for CDOTSC-34) is currently believed
to not have an impact on the user interface element where the user opts
in to the more extensive review.
References:
* [CDOTSC-34] CDO should provide shapes for external ontologies and
other RDF models, including OWL
* RDFLib/pySHACL#170
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nistajnelson-nist added this to the 0.12.0 milestone Aug 25, 2023
@ajnelson-nistajnelson-nist mentioned this pull request Aug 25, 2023
2 tasks
@ajnelson-nist
ajnelson-nist marked this pull request as ready for review August 25, 2023 15:31
@ajnelson-nist
ajnelson-nist requested a review from a team as a code ownerAugust 25, 2023 15:31
@kchason
kchason merged commit 7e70f74 into mainAug 25, 2023
@kchason
kchason deleted the release-0.12.0 branch August 25, 2023 17:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ajnelson-nist@kchason