Skip to content

case_sparql_select: Refactor code - #90

Merged
kchason merged 1 commit into
developfrom
case_sparql_select_refactor
Dec 8, 2022
Merged

case_sparql_select: Refactor code#90
kchason merged 1 commit into
developfrom
case_sparql_select_refactor

Conversation

@ajnelson-nist

Copy link
Copy Markdown
Member

This patch is code-motion to give function names to chunks of case_sparql_select:main.

Some upcoming patch series are going to add features that, when taken together, introduce non-trivial parameter-value cross-dependencies.

Moving functionality to functions enables combinatoric testing in a pytest space, rather than resorting to copying, pasting, and tweaking many Makefile lines. A future patch series will add the pytest script.

This patch is code-motion to give function names to chunks of
`case_sparql_select:main`.
Some upcoming patch series are going to add features that, when taken
together, introduce non-trivial parameter-value cross-dependencies.
Moving functionality to functions enables combinatoric testing in a
`pytest` space, rather than resorting to copying, pasting, and tweaking
many Makefile lines. A future patch series will add the `pytest`
script.
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist

ajnelson-nist commented Dec 7, 2022

Copy link
Copy Markdown
MemberAuthor

The upcoming features include flags to turn off column headers and row headers, and JSON output using another pandas.DataFrame method. It turns out in some cases these are not entirely compatible with one another.

@ajnelson-nist
ajnelson-nist marked this pull request as ready for review December 8, 2022 13:53
@kchason
kchason merged commit 98d4c6b into developDec 8, 2022
@ajnelson-nist
ajnelson-nist deleted the case_sparql_select_refactor branch April 28, 2023 20:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ajnelson-nist@kchason