Uh oh!
There was an error while loading. Please reload this page.
feat: TouchSlider for Modals - #83
Closed
shpindler wants to merge 3 commits into
Closed
Conversation
shpindlerforce-pushed
the
feature/touch-slider
branch
from
November 1, 2023 07:59
e4095ce to
d13a77eCompareshpindler
marked this pull request as draft
November 3, 2023 23:40
shpindler
marked this pull request as ready for review
November 3, 2023 23:40
ingria
commented
Nov 18, 2023
Contributor
Thank you for your effort, but unfortunately we cannot accept your solution because it performs poorly on both desktop and mobile devices. It doesn't detect gestures (swipes) and doesn't handle scroll events properly, also there are major problems with UX in general. Demo: Mobile UX: Desktop UX: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo