fix(#879): landing-page acceptance sweep — real repo URL, working copy-paste command - #982
Merged
Merged
Conversation
…the copy-paste command Final pass over the landing page against #879's acceptance criteria. Two user-visible fixes and two stale-comment retirements: - BibTeX cited https://github.com/aking526/penn-generative-agents, a repository the plan of record no longer creates: #875 (updated 2026-08-04) flips THIS repo public on Aug 14 instead of exporting a standalone one. REPO_URL now points at ccb/agent-sandbox, live once #884 flips visibility. - The Run-it command block rendered its line continuation as two backslashes (\\ in the template literal is the two-character string), so the copy-pasted serve_penn command broke at the line break. Now a single backslash. - The teaser's TODO(#878) asked for a stand-in still from the selected run; #878 is closed and the frozen run IS what the embed plays, so the TODO retires rather than resolves. - index.html's no-og:image comment still promised a poster frame from the #881 video (deferred 2026-08-03); reworded to record the deliberate absence. Swept the remaining criteria: no rendered video surface (all mentions are deferral comments), no placeholder copy or dead navigation, #llm/ #game stay unrouted, serve_penn's --brain/--steps/--max-cost flags all verified against backend/penn/serve_penn.py. Gates: biome 0 errors, Vitest 217/217, tsc + vite build clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
aking526
added a commit
that referenced
this pull request
Aug 5, 2026
#982 (`bcf14599`) retargeted REPO_URL at ccb/agent-sandbox in HomeView while this branch was moving the same constant into `home/links.ts` — same destination URL, so the resolution keeps the shared module and folds #982's better rationale (the plan of record flips THIS repo public, rather than exporting a standalone one) into its docblock. #982 also fixed the doubled backslash in RunLocallySection's LLM_RUN block. That block is deleted on this branch, so the fix has nothing left to apply to; the copy-pasteable command now lives in the README instead. Everything else from prod merged clean, including the teaser's retired TODO(#878). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The closing pass over the #879 landing page, against its acceptance criteria. Two user-visible fixes, two stale-comment retirements:
REPO_URLpointed ataking526/penn-generative-agents, but the plan of record (Epic: Finalize Penn Campus Generative Agents showcase for 2026-08-07 #875, updated 2026-08-04 with the [release] Retire restricted art before the public repo publish #876 in-place history purge) flips this repo public on Aug 14 — no standalone export. The citation (and the commented-out Code button) now point atccb/agent-sandbox.\\\\in the template literal renders as two backslashes at the line break, so the pastedserve_penn.py --brain llmcommand errored. Now a single backslash.TODO(#878)(stand-in still) retired: [finalization] Produce and freeze the five-agent showcase replay #878 is closed and the frozen showcase run is exactly what the embed plays.index.html's no-og:image comment still promised a poster frame from the [demo] Record, caption, and publish the 5–7 minute project video (deferred — not shipping for Aug 7) #881 video (deferred 2026-08-03); reworded to record the deliberate absence.Acceptance audit (the criteria this closes #879 against)
TODO(#880)blocks are the documented post-[release] Flip this repository public (2026-08-14) #884 subsection restorations, not rendered content; all "video" mentions are deferral comments, no rendered surface.#llm/#gameremain unrouted (single commented block inApp.tsx); retired hashes fall back to the landing page per the epic's 2026-08-02 restatement.--brain/--steps/--max-costand the paused-boot claim verified againstbackend/penn/serve_penn.py. (Note: "boots paused; no calls yet" becomes fully true once fix(#934): defer plan authorship under --start-paused to the first tick #981 — the serve_penn --start-paused burns paid plan calls for the default cast before /config re-casts #934 defer-plans fix, open againstmain— merges; before it, boot authored plans at attach time.)tsc -b && vite buildclean.Responsive behavior (390/768/desktop) was exercised under #877's QA and is unchanged here.
After merge
#879 can close (a PR into
prodwon't auto-close it — non-default branch). Reminder for the next main→prod sync: #979'sreplay.tsmirror and #980's regeneratedcheck_out_book.tool.jsonsnippet need carrying over once those merge tomain.🤖 Generated with Claude Code