Skip to content

docs: close the README's run-locally gaps; port the two commented guide sections (#880) - #987

Merged
aking526 merged 2 commits into
prodfrom
agent/880-readme-guide
Aug 5, 2026
Merged

docs: close the README's run-locally gaps; port the two commented guide sections (#880)#987
aking526 merged 2 commits into
prodfrom
agent/880-readme-guide

Conversation

@aking526

@aking526 aking526 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What

The README on prod is the canonical run-locally copy (#984). This PR closes its gaps against #880's criteria and moves the two landing-page subsections that were commented out "until #884" into it, per the amended scope:

  • Setup-screen flow: the paid workflow now documents the paused boot → viewer → setup screen (cast + knobs) → Start path, and --brain mock --start-paused as the free rehearsal.
  • Invalid configuration: new "If something goes wrong" entry — the setup screen surfaces the server's 400 detail under Start.
  • Licensed art: found by the clean-checkout test — a fresh clone renders a gray map because the three licensed packs are absent by design ([release] Retire restricted art before the public repo publish #876) and the README never pointed at ASSETS.md. Now it does, up front and in the failure list.
  • "What's on by default" and "Adding your own verb" ported from the commented JSX in HomeView.tsx / ImplementationSection.tsx into the README; the dead comment blocks, their TODOs, and the toc.ts placeholders are deleted. The verb guide quotes snippets/my_verb.py verbatim and a new pin test in test_landing_snippets.py keeps it byte-identical to the template the suite already proves compiles against the real Action base class.
  • RunLocallySection's closing sentence now names the two new README sections instead of "ships alongside the code package".

Verified

  • Clean-checkout E2E (mock, per the issue criterion as amended): fresh clone → uv sync --extra server → mock backend → run.sh scenes/viewer.tscn connects over /live//events/WebSocket with zero errors once assets are dropped in per ASSETS.md; --start-paused reports configurable, a bad knob 400s with a named detail (plan 'llm' needs the llm brain), and a cast-only POST /config + /resume starts the day with exactly the chosen cast.
  • All CI gates locally: black, 1229+886+204 pytest, validate_tmj, Godot smoke (7 scenes), web lint/test/build (249), mkdocs --strict.

Closes #880.

🤖 Generated with Claude Code

aking526 and others added 2 commits August 5, 2026 10:29
The README is the canonical run-locally copy (#984); this closes its gaps
against the issue's criteria and moves the two subsections that were
commented out on the landing page into it:

- Paid live workflow now documents the paused boot -> viewer -> setup
  screen (cast + knobs) -> Start flow, and how to rehearse it for free
  with --brain mock --start-paused.
- 'If something goes wrong' gains the invalid-configuration entry: the
  setup screen surfaces the server's 400 detail under Start.
- 'What's on by default' (unconditional / provider-gated / knobbed
  faculties + the showcase config) ported from HomeView's commented JSX.
- 'Adding your own verb' ported from ImplementationSection's commented
  JSX, quoting snippets/my_verb.py verbatim; a new pin test keeps the
  README block byte-identical to the template that
  test_landing_snippets.py already proves compiles against the engine.

The commented JSX blocks, their TODOs, and toc.ts placeholders are
deleted — the content's home is the README now, not a future restore.
RunLocallySection's closing sentence points at the two new sections
instead of a vague 'ships alongside the code package'.

Refs #880.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…880)

Found by the clean-checkout test this issue requires: the free live
workflow boots, but the viewer renders a gray map because the three
licensed art packs are deliberately absent from the repository (#876,
no-redistribution licenses) and the README never mentioned ASSETS.md.
Missing sheets also cascade into a viewer.gd script error, so the
symptom is not obviously 'assets'.

- Free live workflow opens with the one-time ASSETS.md drop-in step.
- 'If something goes wrong' gains the gray-map entry.

Refs #880.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@aking526
aking526 merged commit 4011f06 into prod Aug 5, 2026
7 checks passed
@aking526
aking526 deleted the agent/880-readme-guide branch August 5, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant