dx: Add additional hooks to pre-commit - #7

Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom
s373nZ:7765-pre-commit-hooks
Closed

dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom
s373nZ:7765-pre-commit-hooks

Conversation

@s373nZ

@s373nZs373nZ commented Nov 29, 2024•
edited
Loading

Copy link
Copy Markdown

Adds additional hooks to pre-commit.

  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.

Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.

@s373nZ

s373nZ commented Nov 30, 2024

Copy link
Copy Markdown
Author

Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.

@s373nZ

s373nZ commented Dec 1, 2024

Copy link
Copy Markdown
Author

Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.

Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.

Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.

@s373nZ

s373nZ commented Dec 1, 2024

Copy link
Copy Markdown
Author

Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).

@s373nZ
s373nZforce-pushed the 7765-pre-commit-hooks branch from b531f46 to 41003eeCompareDecember 16, 2024 18:14
@s373nZ

s373nZ commented Dec 16, 2024

Copy link
Copy Markdown
Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.

@s373nZ

s373nZ commented Dec 17, 2024

Copy link
Copy Markdown
Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.

@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed the 7765-pre-commit-hooks branch from e5560cd to 3265aeaCompareDecember 18, 2024 19:35
@s373nZ

s373nZ commented Dec 18, 2024

Copy link
Copy Markdown
Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.

Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.

This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.

@s373nZs373nZ mentioned this pull request Mar 11, 2025
Merged
1 task
@s373nZ

s373nZ commented Apr 1, 2025

Copy link
Copy Markdown
Author

Closing in favor of ElementsProject#8193 against CLN repo.

@s373nZs373nZ closed this Apr 1, 2025
cdecker pushed a commit that referenced this pull request Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit that referenced this pull request Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit that referenced this pull request May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit that referenced this pull request May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit that referenced this pull request May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
dx: Add additional hooks to pre-commit - #7
Closed
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Closed
dx: Add additional hooks to pre-commit#7
s373nZ wants to merge 7 commits into
cdecker:202449-pre-commitfrom 
s373nZ:7765-pre-commit-hooks
Conversation
@s373nZ
@s373nZs373nZ
commented
Nov 29, 2024•

edited

Loading

Copy link


Copy Markdown

Adds additional hooks to pre-commit.
  • The official shellcheck hook.
  • Re-implements make check-amount-access as a local pygrep hook.
  • Implements a clang-format hook to fail on suggestion warnings with additional configuration to sort includes.
  • Re-implements make check-discouraged-functions as a local pygrep hook.
Adding this PR (along with future hooks to come) against your PR for now, until ElementsProject#7884 is merged.
@s373nZ
s373nZ
commented
Nov 30, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-amount-access check. Demonstrates a locally defined hook using pygrep and therefore the regex has been converted from piped grep commands into Python format.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an initial version of a clang-format check. Default behavior is to do in-place editing of the files, but that is overridden and suggestion warnings are reported as errors to force a failure. Output in this fashion isn't exactly easy to see the full context of the suggestion, but one can run the full checks and inspect a diff for more of an overview.
Noticed an existing config in .clang-format and added additional instruction to sort #includes in hopes of eventually replacing make check-src-include-order and make check-hdr-include-order.
Also probably needs some more attention around which files to exclude, in accordance with the SRC_TO_CHECK and ALL_NONGEEN_HEADERS definitions in the Makefile.
@s373nZ
s373nZ
commented
Dec 1, 2024

Copy link


Copy Markdown

Author
Added an implementation of the make check-discouraged-functions check, also as a Python regex. There might be another static analysis tool that could also do this (and more?).
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
b531f46 to
41003eeCompareDecember 16, 2024 18:14
@s373nZ
s373nZ
commented
Dec 16, 2024

Copy link


Copy Markdown

Author
  • Cleaned up regex syntax for earlier hooks.
  • Added codespell to check spelling.
@s373nZ
s373nZ
commented
Dec 17, 2024

Copy link


Copy Markdown

Author
  • Added check-jsonschema hooks to validate doc/ JSON schemas and native pre-commit hook for pretty formatting.
@s373nZ
chore: Add amount access check to pre-commit.
4f2e630
Reimplements `make check-amount-access` for Python regex.
@s373nZ
chore: Add clang-format to pre-commit.
d0eef43
Also intends to replace `make check-src-include-order` and
`make check-hdr-include-order` by adding configuration to check
for include ordering.
@s373nZ
chore: Add discouraged function check to pre-commit.
a455383
Reimplements `make check-discouraged-functions` for Python regex.
@s373nZ
chore: Add codespell to pre-commit.
4edc6f5
Includes default config file and an initial word list to ignore.
@s373nZ
chore: Add doc JSON schema checks and formatting to pre-commit.
6ff1ff2
@s373nZ
chore: Add conventional commit linting to pre-commit.
3265aea
@s373nZ
s373nZforce-pushed
the
7765-pre-commit-hooks
branch
from
e5560cd to
3265aeaCompareDecember 18, 2024 19:35
@s373nZ
s373nZ
commented
Dec 18, 2024

Copy link


Copy Markdown

Author
  • Added conventional commit linting for commit messages. Looks like the also gets processed by codespell.
Grabbed the list of "scopes" from top level directory organization, along with a sane perusal of the commit messages from the last few months. Needs some auditing.
This hook utilization requires running pre-commit install --hook-type commit-msg. Would be cool to brainstorm a way to bootstrap the contributor environment with one command, like a Makefile target or script, if possible.
@s373nZs373nZ
mentioned this pull request
Mar 11, 2025
 Merged

1 task
@s373nZ
s373nZ
commented
Apr 1, 2025

Copy link


Copy Markdown

Author
Closing in favor of ElementsProject#8193 against CLN repo.
@s373nZs373nZ
closed this
Apr 1, 2025
cdecker pushed a commit
that referenced
this pull request
Oct 27, 2025
@rustyrussell
plugins: fix %*.s typo.
8f6d3d8
And add a check for new uses creeping in, since it got cut & paste
everywhere.
This means "this is a valid string, but truncate it to this many characters"
vs "%.*s" which means "only read this many characters of string":
```
['lightningd-3 2025-10-23T02:31:40.890Z **BROKEN** plugin-funder: Plugin marked as important, shutting down lightningd!']
--------------------------- Captured stderr teardown ---------------------------
#0 0x557da58ad1dc in printf_common(void*, char const*, __va_list_tag*) asan_interceptors.cpp.o
#1 0x557da5aff814 in json_out_addv /home/runner/work/lightning/lightning/ccan/ccan/json_out/json_out.c:239:11
#2 0x557da59740ce in plugin_logv /home/runner/work/lightning/lightning/plugins/libplugin.c:1777:2
#3 0x557da5969b6f in plugin_log /home/runner/work/lightning/lightning/plugins/libplugin.c:1934:2
#4 0x557da595c4f6 in datastore_del_success /home/runner/work/lightning/lightning/plugins/funder.c:161:2
#5 0x557da598b837 in handle_rpc_reply /home/runner/work/lightning/lightning/plugins/libplugin.c:1072:10
#6 0x557da598a4b0 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1361:3
#7 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
ElementsProject#8 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#9 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#10 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#11 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#12 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#13 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
ElementsProject#14 0x7f6572229e3f in __libc_start_main csu/../csu/libc-start.c:392:3
ElementsProject#15 0x557da588b584 in _start (/home/runner/work/lightning/lightning/plugins/funder+0x10d584) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
0x624000009d28 is located 0 bytes to the right of 7208-byte region [0x624000008100,0x624000009d28)
allocated by thread T0 here:
#0 0x557da590e7f6 in __interceptor_realloc (/home/runner/work/lightning/lightning/plugins/funder+0x1907f6) (BuildId: 71ba63ab577fc6fa60573d3e8555f6db7d5c584d)
#1 0x557da5b2149b in tal_resize_ /home/runner/work/lightning/lightning/ccan/ccan/tal/tal.c:755:13
#2 0x557da59f2032 in membuf_tal_resize /home/runner/work/lightning/lightning/common/utils.c:203:2
#3 0x557da5b03934 in membuf_prepare_space_ /home/runner/work/lightning/lightning/ccan/ccan/membuf/membuf.c:45:12
#4 0x557da59d4289 in jsonrpc_io_read_ /home/runner/work/lightning/lightning/common/jsonrpc_io.c:127:2
#5 0x557da598a635 in rpc_conn_read_response /home/runner/work/lightning/lightning/plugins/libplugin.c:1366:9
#6 0x557da5adbea5 in next_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:60:9
#7 0x557da5ae06ff in do_plan /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:422:8
ElementsProject#8 0x557da5adfb58 in io_ready /home/runner/work/lightning/lightning/ccan/ccan/io/io.c:439:10
ElementsProject#9 0x557da5aec2ce in io_loop /home/runner/work/lightning/lightning/ccan/ccan/io/poll.c:455:5
ElementsProject#10 0x557da59757ac in plugin_main /home/runner/work/lightning/lightning/plugins/libplugin.c:2409:3
ElementsProject#11 0x557da594fe23 in main /home/runner/work/lightning/lightning/plugins/funder.c:1723:2
ElementsProject#12 0x7f6572229d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
SUMMARY: AddressSanitizer: heap-buffer-overflow asan_interceptors.cpp.o in printf_common(void*, char const*, __va_list_tag*)
Shadow bytes around the buggy address:
0x0c487fff9350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9360: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9370: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0c487fff9390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c487fff93a0: 00 00 00 00 00[fa]fa fa fa fa fa fa fa fa fa fa
0x0c487fff93b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c487fff93f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==26122==ABORTING
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
Nov 27, 2025
Chandra Pratap@rustyrussell
fuzz-tests: Add a wire test for wireaddr functions
a59d21d
Changelog-None: `towire_wireaddr()` and `fromwire_wireaddr()` in
`common/wireaddr.h` are responsible for marshalling/unmarshalling
BOLT #7 address descriptors.
Since these aren't tested by the existing wire fuzz tests, add a
roundtrip test for them. This has the added benefit of testing
`parse_wireaddr()` as well.
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
BOLT quote corrections in Python files (previously unchecked).
c7baf64
Update BOLT quotes in test and library Python files to match current BOLT
text: punctuation (periods to semicolons), capitalization (Lightning on
Bitcoin mainnet), fix field ordering in invoice breakdowns, add ... to skip
features fields and SHA256 hex details, correct backtick-quoting of field
names, and remove incorrect BOLT #7 label from a plain comment.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
tests: update test_forward_different_fees_and_cltv to use default min…
6669d07
…_final_cltv_expiry_delta.
The BOLT #7 was updated to use the new default 18 as min_final_cltv_expiry_delta, so
update our quote and test, and fix other textual spec changes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker pushed a commit
that referenced
this pull request
May 14, 2026
@rustyrussell
Update outdated BOLT quotes in channel open/close handling.
39ac3f1
Some of these are malformed (thus were unchecked!), some are from the
stricter interpretation of `...` which won't cross section boundaries.
Several BOLT quotes had drifted from the current spec text:
- connectd/queries.c: BOLT #7 uses 'full_information' not 'complete';
remove a second quote that referenced query_channel_range but was
actually wrong (that requirement is for query_short_channel_ids).
- lightningd/dual_open_control.c: channel reserve is 1% rounded down
(not just 1%); witness weight check now says SHOULD broadcast rather
than MUST fail; RBF quotes simplified to match actual BOLT wording.
- openingd/openingd.c: 'The sending node' became 'The sender';
invalid signature response now says MUST send warning/error not just
MUST fail the channel.
- openingd/dualopend.c: same invalid-signature quote as openingd.c.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@s373nZ