Fix OpenAPI v3.0 Schema Violation: Array value found, but an object is required - #125
Closed
thejamescollins wants to merge 2 commits into
Closed
Fix OpenAPI v3.0 Schema Violation: Array value found, but an object is required#125thejamescollins wants to merge 2 commits into
thejamescollins wants to merge 2 commits into
Conversation
Otherwise these fail validation against the OpenAPI v3.0 schema.
cebe added a commit
that referenced
this pull request
Feb 9, 2022
cebe
commented
Feb 9, 2022
Owner
Rebased onto master here: #152 Thank you! |
cebe added a commit
that referenced
this pull request
Feb 9, 2022
* master: (22 commits) Catch recursion when resolving inside included file Improve Responses resolving references Fixes default value for exclusiveMinimum and exclusiveMaximum more specific deprecation add hasPropertyValue() method add comments, optimize tests for #125 During serialization convert empty Map fields to empty Objects Add test to demonstrate OpenAPI v3.0 schema validation fails with empty Path properties yarn upgrade Added docker environment for local development Add symfony 6 support (#151) Bump node-fetch from 2.6.1 to 2.6.7 (#149) Fix CI badge in Readme (#150) Temporarily skip broken test (#145) Run speccy through yarn Add windows and macos cases Temporarily skip broken test Rework CI Run all tests (#136) Drop licence badge from readme (#137) ... Conflicts: README.md composer.json src/SpecBaseObject.php tests/ReaderTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thank you for your very useful tool, it's been really useful in our projects.
bin/php-openapi validatecurrently fails unexpectedly when validating a schema that specifies an empty value for a Map OpenAPI field.For example, the minimal specification I've provided in c5ca523 currently fails:
Whereas that specification passes in various other validation tools such as https://apitools.dev/swagger-parser/online/ or https://www.jsonschemavalidator.net/.
This PR changes to the Serialization process so that empty Map Fields are correctly validated.
The example in this PR uses the Response object, however, the fix should apply for any Map type fields.