Skip to content

Add Testcases for OpenAPI 3.1 - #129

Merged
cebe merged 2 commits into
cebe:openapi-31from
marcelthole:add-openapi31-examples
Oct 31, 2021
Merged

Add Testcases for OpenAPI 3.1#129
cebe merged 2 commits into
cebe:openapi-31from
marcelthole:add-openapi31-examples

Conversation

@marcelthole

@marceltholemarcelthole commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Resolves#108

@marceltholemarcelthole mentioned this pull request Oct 20, 2021
Merged
marcelthole
marcelthole commented Oct 20, 2021
View reviewed changes
Comment threadtests/spec/OpenApiTest.php
cebe
cebe reviewed Oct 21, 2021
View reviewed changes
Comment threadtests/spec/OpenApiTest.php
@cebecebe added this to the 1.6.0 milestone Oct 27, 2021
@cebe

cebe commented Oct 28, 2021

Copy link
Copy Markdown
Owner

something's wrong with the tests here, no checks were run for that commit!?

@cebe

cebe commented Oct 28, 2021

Copy link
Copy Markdown
Owner

Found it: the openapi-31 branch was not included in the github actions trigger list.

@marcelthole

marcelthole commented Oct 29, 2021

Copy link
Copy Markdown
ContributorAuthor

So this could be merged after the #128 is resolved?

@cebe
cebe merged commit 551b05f into cebe:openapi-31Oct 31, 2021
@cebe

cebe commented Oct 31, 2021

Copy link
Copy Markdown
Owner

Merged, thank you!

failing tests are expected in 3.1, these will be resolved when webhook support is merged.

@WyriHaximus

WyriHaximus commented Oct 31, 2021

Copy link
Copy Markdown

Awesome! Will rebase #115 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cebecebecebe left review comments

Assignees

No one assigned

Labels

openapi 3.1

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@marcelthole@cebe@WyriHaximus