Skip to content

WIP: referenced file cache - #67

Merged
cebe merged 9 commits into
masterfrom
wip-reference-cache
Dec 14, 2020
Merged

WIP: referenced file cache#67
cebe merged 9 commits into
masterfrom
wip-reference-cache

Conversation

@cebe

@cebecebe commented Mar 27, 2020

Copy link
Copy Markdown
Owner

cebe added 2 commits March 20, 2020 20:33
simple cache implementation
does not yet normalize relative paths in URIs
@cebecebe added the enhancement New feature or request label Mar 27, 2020
@cebecebe mentioned this pull request Mar 27, 2020
@cebecebe added this to the 1.5.0 milestone Mar 27, 2020
@araines

Copy link
Copy Markdown

@cebe is there anything I can do to help with this one? Your tool is great, but we cannot use it with our project as we make heavy usage of references and the currently released version gets stuck in loops. It looks to me like this fix should actually resolve that issue.

@cebe

cebe commented Apr 15, 2020

Copy link
Copy Markdown
OwnerAuthor

These changes are currently creating a bug in one of my project so it is not complete. I can try to provide a test case for it so you can check it out. Thanks for offering your help.

@cebecebe self-assigned this Jul 10, 2020
@kohlerdominik

Copy link
Copy Markdown

Hi @cebe
Is there an ETA for this feature?

@cebe

cebe commented Sep 27, 2020

Copy link
Copy Markdown
OwnerAuthor

No ETA, but I try to get it done soon ;-)

@stevethitchman

Copy link
Copy Markdown

Hi @cebe did you manage to implement a test case for the bug you were having on one of your projects, it looks like you may have? I may be able to put some time into this if so as it's recently become an issue on a project and from a quick test these changes seem to pretty much resolve it

Comment threadsrc/spec/Reference.php Outdated
Comment threadsrc/Reader.php Outdated
Comment threadsrc/Reader.php Outdated
@cebe
cebe merged commit 015bd48 into masterDec 14, 2020
@cebe
cebe deleted the wip-reference-cache branch December 14, 2020 22:42
@cebe

cebe commented Dec 14, 2020

Copy link
Copy Markdown
OwnerAuthor

@stevethitchman thanks for offering your help. It turned out to be an issue in the project code.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to inline only external references Improve resolving references, cache loaded files in current context

4 participants

@cebe@araines@kohlerdominik@stevethitchman