Uh oh!
There was an error while loading. Please reload this page.
update for cedar#726 (version numbers) - #106
Merged
Merged
Conversation
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
aaronjeline
approved these changes
Mar 15, 2024
khieta
approved these changes
Mar 15, 2024
khieta
left a comment
There was a problem hiding this comment.
Approving as-is, but left a couple small comments.
Comment on lines
+13
to
+14
| thiserror = "1.0.49" | ||
| itertools = "0.11.0" |
There was a problem hiding this comment.
For consistency with our other repos
Suggested change
| thiserror = "1.0.49" | |
| itertools = "0.11.0" | |
| thiserror = "1.0" | |
| itertools = "0.12" |
ContributorAuthor
There was a problem hiding this comment.
Was about to fix this but @shaobo-he-aws merged the PR before I had a chance. Feel free to make a followup
| version = "4.0.0" | ||
| [dependencies] | ||
| cedar-policy = { version = "4.0.0", path = "../../cedar/cedar-policy" } |
There was a problem hiding this comment.
A little weird to require cedar-policy to be cloned locally -- switch to using the git trick from https://github.com/cedar-policy/cedar-examples/blob/release/3.1.x/tinytodo/Cargo.toml?
ContributorAuthor
There was a problem hiding this comment.
This is pre-existing, let's make an issue to fix this in a different PR
aaronjeline
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
cedar-policy/cedar#726
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.