Uh oh!
There was an error while loading. Please reload this page.
Update Gradle build to download integration tests - #114
Merged
andrewmwells-amazon merged 3 commits intoMar 25, 2024
Merged
Conversation
- Added macOS to GitHub CI workflow Signed-off-by: David Handermann <exceptionfactory@apache.org>
khieta
approved these changes
Mar 25, 2024
khieta
left a comment
There was a problem hiding this comment.
This seems like a good change to me. Can you also update the README to remove the "Integration Testing" section?
Signed-off-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
exceptionfactory
commented
Mar 25, 2024
ContributorAuthor
Thanks for the review @khieta! I removed the Integration Testing section and also updated the main project |
andrewmwells-amazon
approved these changes
Mar 25, 2024
andrewmwells-amazon
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the PR!
khieta pushed a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This pull request updates the Gradle configuration to download the
mainbranch of the Cedar repository, incorporating integration testing in the standard build. The gradle-download-task handles the HTTP request to the GitHub URL, downloading the Zip archive of the Cedar repository main branch.Instead of setting the integration tests path from an environment variable, the Gradle tasks extract the Cedar repository archive to the build test resources directory. This approach makes the integration test corpus available as a class path resource. Updates to the
SharedIntegrationTestsclass resolve the directory from the class path location.Additional changes include updating the continuous integration workflow to run on both Ubuntu Linux and macOS 14. The macOS 14 runner uses AArch64 architecture. The updated workflow installs Zig using the platform-specific package manager, and also includes the setup-java action to provide a consistent vendor and version of the JDK.