Skip to content

Helper DeclareContextProto to extend CEL environment - #446

Merged
TristonianJones merged 1 commit into
cel-expr:masterfrom
hickford:declare-context-proto
Aug 18, 2021
Merged

Helper DeclareContextProto to extend CEL environment#446
TristonianJones merged 1 commit into
cel-expr:masterfrom
hickford:declare-context-proto

Conversation

@hickford

@hickfordhickford commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Helper DeclareContextProto to extend CEL environment with declarations from the given context proto. Each field of the proto defines a variable of the same name in the environment (https://github.com/google/cel-spec/blob/master/doc/langdef.md#evaluation-environment).

TESTED=bazel test ...

@hickford
hickford marked this pull request as draft August 12, 2021 10:47
@hickford
hickfordforce-pushed the declare-context-proto branch from 9dfa0b7 to 0d6d873CompareAugust 12, 2021 10:57
@hickford
hickford marked this pull request as ready for review August 12, 2021 10:58
@hickford

hickford commented Aug 12, 2021

Copy link
Copy Markdown
ContributorAuthor

@TristonianJones Here's the review discussed elsewhere

@TristonianJones

TristonianJones commented Aug 12, 2021

Copy link
Copy Markdown
Collaborator

/gcbrun

TristonianJones
TristonianJones reviewed Aug 12, 2021
View reviewed changes
Comment threadcel/options.go Outdated
Comment threadcel/options.go Outdated
Comment threadcel/options.go Outdated
Comment threadcel/cel_test.go Outdated
@hickford
hickfordforce-pushed the declare-context-proto branch 2 times, most recently from f12979e to 72baebcCompareAugust 13, 2021 10:28
@hickford

hickford commented Aug 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for your comments. Ready for review again.

@TristonianJones

TristonianJones commented Aug 13, 2021

Copy link
Copy Markdown
Collaborator

/gcbrun

TristonianJones
TristonianJones reviewed Aug 13, 2021
View reviewed changes
Comment threadcel/cel_test.go Outdated
Comment threadcel/cel_test.go Outdated
Comment threadcel/options.go Outdated
Comment threadcel/options.go Outdated
Comment threadcel/options.go Outdated
Comment threadcel/options.go Outdated
Comment threadcel/testdata/testprotovalue.proto Outdated
@hickford
hickfordforce-pushed the declare-context-proto branch from 72baebc to abbf264CompareAugust 16, 2021 11:41
@hickford

hickford commented Aug 16, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks again, ready.

@hickford
Helper DeclareContextProto to extend CEL environment with declaration…
97c5bc4
…s from the given context proto. Each field of the proto defines a variable of the same name in the environment (https://github.com/google/cel-spec/blob/master/doc/langdef.md#evaluation-environment).
TESTED=bazel build ... && bazel test ...
@hickford
hickfordforce-pushed the declare-context-proto branch from abbf264 to 97c5bc4CompareAugust 16, 2021 13:26
@TristonianJones

TristonianJones commented Aug 17, 2021

Copy link
Copy Markdown
Collaborator

/gcbrun

@TristonianJones
TristonianJones merged commit cd8abd3 into cel-expr:masterAug 18, 2021
@snazysnazy mentioned this pull request Aug 30, 2021
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TristonianJonesTristonianJonesTristonianJones approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hickford@TristonianJones