Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 27, 2026
Merged

Make invariant violation messages policy-specific #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions verifier/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
default_applicable_licenses = ["//:license"],
default_visibility = ["//:internal"],
default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
"//...",
]

package_group(
name = "verifier_allow_list",
packages = VERIFIER_ALLOW_LIST,
)

package_group(
name = "verifier_internal",
packages = ["//verifier/..."],
)

java_library(
name = "verifier",
visibility = [
"//:internal",
],
exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
name = "verifier_factory",
compatible_with = [],
visibility = [
"//:internal",
],
exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
name = "type_system",
compatible_with = [],
visibility = ["//:internal"],
visibility = [":verifier_internal"],
exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
name = "z3_impl",
compatible_with = [],
visibility = ["//:internal"],
visibility = [":verifier_internal"],
exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)
2 changes: 1 addition & 1 deletion verifier/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
System.out.println("Invariant violated!");
System.out.println(result.message());
// Output:
// Implication violation detected. Counterexample input:
// Invariant 'always_secure' violation detected. Counterexample input:
// port = 80
break;
case INCONCLUSIVE:
Expand Down
9 changes: 7 additions & 2 deletions verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
throw new UnsupportedOperationException(
"Invariants verification requires Z3 verifier implementation.");
}
String invariantId = invariant.invariantId().value();
CelVerificationResult result =
((CelVerifierZ3Impl) astVerifier)
.verifyImplication(assumeAst, assertAst, boundSymbols);
resultsBuilder.put(invariant.invariantId().value(), result);
.verifyImplication(
assumeAst,
assertAst,
boundSymbols,
String.format("Invariant '%s'", invariantId));
resultsBuilder.put(invariantId, result);
}

return resultsBuilder.buildOrThrow();
Expand Down
38 changes: 30 additions & 8 deletions verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
/** Returns the status of the verification check. */
public abstract VerificationStatus status();

/**
* Returns the primary reason for the verification outcome.
*/
public abstract String reason();

/**
* Returns a detailed counterexample or satisfying model assignment, if one was found.
*/
public abstract String counterexample();

/**
* Returns a message detailing the outcome of the verification check, such as a counterexample
* input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
* and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
*/
public abstract String message();
public String message() {
return reason() + counterexample();
}

static CelVerificationResult verified() {
return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
}

static CelVerificationResult verified(String reason) {
return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
}

static CelVerificationResult failed(String reason) {
return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
}

static CelVerificationResult verified(String message) {
return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
static CelVerificationResult failed(String reason, String counterexample) {
return new AutoValue_CelVerificationResult(
VerificationStatus.VIOLATED, reason, counterexample);
}

static CelVerificationResult failed(String message) {
return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
static CelVerificationResult inconclusive(String reason) {
return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
}

static CelVerificationResult inconclusive(String message) {
return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
static CelVerificationResult inconclusive(String reason, String counterexample) {
return new AutoValue_CelVerificationResult(
VerificationStatus.INCONCLUSIVE, reason, counterexample);
}
}
92 changes: 47 additions & 45 deletions verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
switch (result.outcome) {
case EXACT_MATCH:
return CelVerificationResult.failed(
"Equivalence violation detected."
+ getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
"Equivalence violation detected.",
getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
case APPROXIMATE_MATCH:
return CelVerificationResult.inconclusive(
"Inconclusive: a divergence may exist, but it depends on approximations, missing"
+ " theories, or loop bounds."
+ getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
+ " theories, or loop bounds.",
getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
case TRUNCATED:
return CelVerificationResult.inconclusive(
"Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
CelVerificationResult verifyImplication(
CelAbstractSyntaxTree assumeAst,
CelAbstractSyntaxTree assertAst,
Map<String, CelAbstractSyntaxTree> boundSymbols)
Map<String, CelAbstractSyntaxTree> boundSymbols,
String subjectName)
throws CelVerificationException {
Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
switch (result.outcome) {
case EXACT_MATCH:
return CelVerificationResult.failed(
"Implication violation detected."
+ getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
case APPROXIMATE_MATCH:
return CelVerificationResult.inconclusive(
"Inconclusive: a counterexample may exist, but it depends on approximations, missing"
+ " theories, or loop bounds."
+ getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
+ " theories, or loop bounds.",
getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
case TRUNCATED:
return CelVerificationResult.inconclusive(
"Inconclusive: implication holds within the current loop unroll limit, but"
+ " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
+ " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
case NO_MATCH:
return CelVerificationResult.verified();
case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
case EXACT_MATCH:
return searchForCounterexample
? CelVerificationResult.failed(
"Condition is not always true."
+ getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
"Condition is not always true.",
getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
: CelVerificationResult.verified(
"Condition is satisfiable."
+ getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
: "Inconclusive: a satisfying model may exist, but it depends on"
+ " approximations, missing theories, or loop bounds.";
return CelVerificationResult.inconclusive(
prefix
+ getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
prefix,
getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));

case TRUNCATED:
return CelVerificationResult.inconclusive(
Expand Down
3 changes: 2 additions & 1 deletion verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
.isEqualTo(VerificationStatus.VIOLATED);
assertThat(results.get("universal_no_unapproved_privileged_prod").message())
.isEqualTo(
"Implication violation detected. Counterexample input:\n"
"Invariant 'universal_no_unapproved_privileged_prod' violation detected."
+ " Counterexample input:\n"
+ " is_owner = false\n"
+ " is_privileged = true\n"
+ " is_prod = true\n"
Expand Down
2 changes: 1 addition & 1 deletion verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
CelVerificationResult result =
((CelVerifierZ3Impl) verifier)
.verifyImplication(assumeAst, assertAst, ImmutableMap.of());
.verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
assertThat(result.message())
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Make invariant violation messages policy-specific#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Jul 27, 2026
 Merged


Make invariant violation messages policy-specific
#1144
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


26 changes: 17 additions & 9 deletions
verifier/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,14 +2,25 @@ load("@rules_java//java:defs.bzl", "java_library")

package(
 default_applicable_licenses = ["//:license"],
 default_visibility = ["//:internal"],
 default_visibility = [":verifier_allow_list"],
)

VERIFIER_ALLOW_LIST = [
 "//...",
]

package_group(
 name = "verifier_allow_list",
 packages = VERIFIER_ALLOW_LIST,
)

package_group(
 name = "verifier_internal",
 packages = ["//verifier/..."],
)

java_library(
 name = "verifier",
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier"],
)

Expand All@@ -27,22 +38,19 @@ java_library(
java_library(
 name = "verifier_factory",
 compatible_with = [],
 visibility = [
 "//:internal",
 ],
 exports = ["//verifier/src/main/java/dev/cel/verifier:verifier_factory"],
)

java_library(
 name = "type_system",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:type_system"],
)

java_library(
 name = "z3_impl",
 compatible_with = [],
 visibility = ["//:internal"],
 visibility = [":verifier_internal"],
 exports = ["//verifier/src/main/java/dev/cel/verifier:z3_impl"],
)

2 changes: 1 addition & 1 deletion
verifier/README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,7 @@ public class InvariantsExample {
 System.out.println("Invariant violated!");
 System.out.println(result.message());
 // Output:
 // Implication violation detected. Counterexample input:
 // Invariant 'always_secure' violation detected. Counterexample input:
 // port = 80
 break;
 case INCONCLUSIVE:
Expand Down

9 changes: 7 additions & 2 deletions
verifier/src/main/java/dev/cel/verifier/CelPolicyVerifierImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,10 +145,15 @@ public ImmutableMap<String, CelVerificationResult> verifyInvariants(CelPolicy po
 throw new UnsupportedOperationException(
 "Invariants verification requires Z3 verifier implementation.");
 }
 String invariantId = invariant.invariantId().value();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) astVerifier)
 .verifyImplication(assumeAst, assertAst, boundSymbols);
 resultsBuilder.put(invariant.invariantId().value(), result);
 .verifyImplication(
 assumeAst,
 assertAst,
 boundSymbols,
 String.format("Invariant '%s'", invariantId));
 resultsBuilder.put(invariantId, result);
 }

 return resultsBuilder.buildOrThrow();
Expand Down

38 changes: 30 additions & 8 deletions
verifier/src/main/java/dev/cel/verifier/CelVerificationResult.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,26 +33,48 @@ public enum VerificationStatus {
 /** Returns the status of the verification check. */
 public abstract VerificationStatus status();

 /**
 * Returns the primary reason for the verification outcome.
 */
 public abstract String reason();

 /**
 * Returns a detailed counterexample or satisfying model assignment, if one was found.
 */
 public abstract String counterexample();

 /**
 * Returns a message detailing the outcome of the verification check, such as a counterexample
 * input, satisfying model assignments, or truncation reason. May be empty if status is VERIFIED
 * and no model inputs apply (e.g., when verifying isAlwaysTrue without counterexamples).
 */
 public abstract String message();
 public String message() {
 return reason() + counterexample();
 }

 static CelVerificationResult verified() {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "");
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, "", "");
 }

 static CelVerificationResult verified(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, reason, "");
 }

 static CelVerificationResult failed(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, reason, "");
 }

 static CelVerificationResult verified(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VERIFIED, message);
 static CelVerificationResult failed(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.VIOLATED, reason, counterexample);
 }

 static CelVerificationResult failed(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.VIOLATED, message);
 static CelVerificationResult inconclusive(String reason) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, reason, "");
 }

 static CelVerificationResult inconclusive(String message) {
 return new AutoValue_CelVerificationResult(VerificationStatus.INCONCLUSIVE, message);
 static CelVerificationResult inconclusive(String reason, String counterexample) {
 return new AutoValue_CelVerificationResult(
 VerificationStatus.INCONCLUSIVE, reason, counterexample);
 }
}

92 changes: 47 additions & 45 deletions
verifier/src/main/java/dev/cel/verifier/CelVerifierZ3Impl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -193,23 +194,23 @@ public CelVerificationResult verifyEquivalence(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
 "Equivalence violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
 "Equivalence violation detected.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a divergence may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: expressions are equivalent within the current loop unroll limit, but"
Expand All@@ -227,7 +228,8 @@ public CelVerificationResult verifyEquivalence(
 CelVerificationResult verifyImplication(
 CelAbstractSyntaxTree assumeAst,
 CelAbstractSyntaxTree assertAst,
 Map<String, CelAbstractSyntaxTree> boundSymbols)
 Map<String, CelAbstractSyntaxTree> boundSymbols,
 String subjectName)
 throws CelVerificationException {
 Preconditions.checkArgument(assumeAst.isChecked(), "assumeAst must be type-checked.");
 Preconditions.checkArgument(assertAst.isChecked(), "assertAst must be type-checked.");
Expand DownExpand Up@@ -282,27 +284,27 @@ CelVerificationResult verifyImplication(
 switch (result.outcome) {
 case EXACT_MATCH:
 return CelVerificationResult.failed(
"Implication violation detected."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true));
String.format("%s violation detected.", subjectName),
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true));
 case APPROXIMATE_MATCH:
 return CelVerificationResult.inconclusive(
 "Inconclusive: a counterexample may exist, but it depends on approximations, missing"
 + " theories, or loop bounds."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ true));
 + " theories, or loop bounds.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ true));
 case TRUNCATED:
 return CelVerificationResult.inconclusive(
 "Inconclusive: implication holds within the current loop unroll limit, but"
 + " may be violated for larger collections.");
String.format("Inconclusive: %s holds within the current loop unroll limit, but"
 + " may be violated for larger collections.", subjectName.toLowerCase(Locale.US)));
 case NO_MATCH:
 return CelVerificationResult.verified();
 case SOLVER_UNKNOWN:
Expand DownExpand Up@@ -345,13 +347,13 @@ private CelVerificationResult checkSatisfiability(
 case EXACT_MATCH:
 return searchForCounterexample
 ? CelVerificationResult.failed(
 "Condition is not always true."
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ false,
/* isCounterexample= */ true))
 "Condition is not always true.",
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ false,
 /* isCounterexample= */ true))
 : CelVerificationResult.verified(
 "Condition is satisfiable."
 + getCounterexampleString(
Expand All@@ -369,13 +371,13 @@ private CelVerificationResult checkSatisfiability(
 : "Inconclusive: a satisfying model may exist, but it depends on"
 + " approximations, missing theories, or loop bounds.";
 return CelVerificationResult.inconclusive(
 prefix
 + getCounterexampleString(
ctx,
translator.getTypeSystem(),
result.model,
/* isApproximate= */ true,
/* isCounterexample= */ searchForCounterexample));
 prefix,
 getCounterexampleString(
 ctx,
 translator.getTypeSystem(),
 result.model,
 /* isApproximate= */ true,
 /* isCounterexample= */ searchForCounterexample));

 case TRUNCATED:
 return CelVerificationResult.inconclusive(
Expand Down

3 changes: 2 additions & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelPolicyVerifierImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -526,7 +526,8 @@ public void verifyInvariants_workloadAdmissionFlawed_violationsDetected() throws
 .isEqualTo(VerificationStatus.VIOLATED);
 assertThat(results.get("universal_no_unapproved_privileged_prod").message())
 .isEqualTo(
 "Implication violation detected. Counterexample input:\n"
 "Invariant 'universal_no_unapproved_privileged_prod' violation detected."
 + " Counterexample input:\n"
 + " is_owner = false\n"
 + " is_privileged = true\n"
 + " is_prod = true\n"
Expand Down

2 changes: 1 addition & 1 deletion
verifier/src/test/java/dev/cel/verifier/CelVerifierZ3ImplTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2604,7 +2604,7 @@ public void verifyImplication_loopExceedsLimit_returnsTruncatedInconclusive() th
 CelVerifierFactory.newVerifier().setComprehensionUnrollLimit(2).build();
 CelVerificationResult result =
 ((CelVerifierZ3Impl) verifier)
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of());
 .verifyImplication(assumeAst, assertAst, ImmutableMap.of(), "Implication");

 assertThat(result.status()).isEqualTo(VerificationStatus.INCONCLUSIVE);
 assertThat(result.message())
Expand Down
Loading