Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,3 +31,5 @@ mvn-artifacts

*.swp
*.lock
.eclipse
.vscode
32 changes: 25 additions & 7 deletions checker/src/main/java/dev/cel/checker/Env.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -451,17 +451,29 @@ public Env add(String name, Type type) {
* until the root package is reached. If {@code container} starts with {@code .}, the resolution
* is in the root container only.
*
* <p>Returns {@code null} if the function cannot be found.
* <p>Returns {@code null} if the ident cannot be found.
*/
public @Nullable CelIdentDecl tryLookupCelIdent(CelContainer container, String name) {
// Attempt to find the decl with just the ident name to account for shadowed variables
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(name);
if (decl != null) {
return decl;
// A name with a leading '.' always resolves in the root scope, bypassing local scopes.
if (!name.startsWith(".")) {
// Check if this is a qualified ident, or a field selection.
String simpleName = name;
int dotIndex = name.indexOf('.');
if (dotIndex > 0) {
simpleName = name.substring(0, dotIndex);
}

// Attempt to find the decl with just the ident name to account for shadowed variables.
CelIdentDecl decl = tryLookupCelIdentFromLocalScopes(simpleName);
if (decl != null) {
// Appears to be a field selection on a local.
// Return null instead of attempting to resolve qualified name at the root scope
return dotIndex > 0 ? null : decl;
}
}

for (String cand : container.resolveCandidateNames(name)) {
decl = tryLookupCelIdent(cand);
CelIdentDecl decl = tryLookupCelIdent(cand);
if (decl != null) {
return decl;
}
Expand DownExpand Up@@ -503,7 +515,13 @@ public Env add(String name, Type type) {
return null;
}

private @Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
/**
* Lookup a local identifier by name. This searches only comprehension scopes, bypassing standard
* environment or user-defined environment.
*
* <p>Returns {@code null} if not found in local scopes.
*/
@Nullable CelIdentDecl tryLookupCelIdentFromLocalScopes(String name) {
int firstUserSpaceScope = 2;
// Iterate from the top of the stack down to the first local scope.
// Note that:
Expand Down
39 changes: 31 additions & 8 deletions checker/src/main/java/dev/cel/checker/ExprChecker.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -237,15 +237,18 @@ private CelExpr visit(CelExpr expr, CelExpr.CelIdent ident) {
if (decl.equals(Env.ERROR_IDENT_DECL)) {
// error reported
env.setType(expr, SimpleType.ERROR);
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(decl.name(), decl));
return expr;
}
if (!decl.name().equals(ident.name())) {

String refName = maybeDisambiguate(ident.name(), decl.name());

if (!refName.equals(ident.name())) {
// Overwrite the identifier with its fully qualified name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
return expr;
}

Expand All@@ -260,13 +263,15 @@ private CelExpr visit(CelExpr expr, CelExpr.CelSelect select) {
env.reportError(expr.id(), getPosition(expr), "expression does not select a field");
env.setType(expr, SimpleType.BOOL);
} else {
String refName = maybeDisambiguate(qname, decl.name());

if (namespacedDeclarations) {
// Rewrite the node to be a variable reference to the resolved fully-qualified
// variable name.
expr = replaceIdentSubtree(expr, decl.name());
expr = replaceIdentSubtree(expr, refName);
}
env.setType(expr, decl.type());
env.setRef(expr, makeReference(decl));
env.setRef(expr, makeReference(refName, decl));
}
return expr;
}
Expand DownExpand Up@@ -595,14 +600,32 @@ private CelExpr visit(CelExpr expr, CelExpr.CelComprehension compre) {
return expr;
}

private CelReference makeReference(CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(decl.name());
private CelReference makeReference(String name, CelIdentDecl decl) {
CelReference.Builder ref = CelReference.newBuilder().setName(name);
if (decl.constant().isPresent()) {
ref.setValue(decl.constant().get());
}
return ref.build();
}

/**
* Returns the reference name, prefixed with a leading dot only if disambiguation is needed.
* Disambiguation is needed when: the original name had a leading dot, and there's a local
* variable that would shadow the resolved name.
*/
private String maybeDisambiguate(String originalName, String resolvedName) {
if (!originalName.startsWith(".")) {
return resolvedName;
}
String simpleName = originalName.substring(1);
int dotIndex = simpleName.indexOf('.');
String localName = dotIndex > 0 ? simpleName.substring(0, dotIndex) : simpleName;
if (env.tryLookupCelIdentFromLocalScopes(localName) != null) {
return "." + resolvedName;
}
return resolvedName;
}

private OverloadResolution resolveOverload(
long callExprId,
int position,
Expand Down
4 changes: 4 additions & 0 deletions checker/src/test/java/dev/cel/checker/ExprCheckerTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -199,6 +199,10 @@ public void referenceTypeRelative() throws Exception {
public void referenceTypeAbsolute() throws Exception {
source = ".cel.expr.conformance.proto3.TestAllTypes";
runTest();

declareVariable("app.config", SimpleType.INT);
source = "[0].exists(app, .app.config == 1)";
runTest();
}

@Test
Expand Down
33 changes: 33 additions & 0 deletions checker/src/test/resources/referenceTypeAbsolute.baseline
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
Source: .cel.expr.conformance.proto3.TestAllTypes
=====>
cel.expr.conformance.proto3.TestAllTypes~type(cel.expr.conformance.proto3.TestAllTypes)^cel.expr.conformance.proto3.TestAllTypes

Source: [0].exists(app, .app.config == 1)
declare app.config {
value int
}
=====>
__comprehension__(
// Variable
app,
// Target
[
0~int
]~list(int),
// Accumulator
@result,
// Init
false~bool,
// LoopCondition
@not_strictly_false(
!_(
@result~bool^@result
)~bool^logical_not
)~bool^not_strictly_false,
// LoopStep
_||_(
@result~bool^@result,
_==_(
.app.config~int^.app.config,
1~int
)~bool^equals
)~bool^logical_or,
// Result
@result~bool^@result)~bool
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,6 +98,11 @@ Optional<AccumulatedUnknowns> maybePartialUnknown(CelAttribute attribute) {

/** Resolve a simple name to a value. */
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// Strip leading dot if present (for global disambiguation).
if (name.startsWith(".")) {
name = name.substring(1);
}

CelAttribute attr = CelAttribute.EMPTY;

if (attributeTrackingEnabled) {
Expand DownExpand Up@@ -154,6 +159,10 @@ private ScopedResolver(

@Override
DefaultInterpreter.IntermediateResult resolveSimpleName(String name, Long exprId) {
// A name with a leading '.' always resolves in the root scope
if (name.startsWith(".")) {
return parent.resolveSimpleName(name, exprId);
}
DefaultInterpreter.IntermediateResult result = lazyEvalResultCache.get(name);
if (result != null) {
return copyIfMutable(result);
Expand Down
34 changes: 33 additions & 1 deletion runtime/src/test/resources/comprehension.baseline
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,4 +19,36 @@ declare com.x {
}
=====>
bindings: {com.x=1}
result: true
result: true

Source: [{'z': 0}].exists(y, y.z == 0)
declare cel.example.y {
value int
}
=====>
bindings: {cel.example.y={z=1}}
result: true

Source: [{'z': 0}].exists(y, y.z == 0 && .y.z == 1)
declare y.z {
value int
}
=====>
bindings: {y.z=1}
result: true

Source: [0].exists(x, x == 0 && .x == 1)
declare x {
value int
}
=====>
bindings: {x=1}
result: true

Source: [0].exists(x, [x+1].exists(x, x == .x))
declare x {
value int
}
=====>
bindings: {x=1}
result: true
20 changes: 20 additions & 0 deletions testing/src/main/java/dev/cel/testing/BaseInterpreterTest.java
Original file line numberDiff line numberDiff line change
Expand Up@@ -863,6 +863,26 @@ public void comprehension() throws Exception {
container = CelContainer.ofName("com");
source = "[0].exists(x, x == 0)";
runTest(ImmutableMap.of("com.x", 1));

clearAllDeclarations();
declareVariable("cel.example.y", SimpleType.INT);
container = CelContainer.ofName("cel.example");
source = "[{'z': 0}].exists(y, y.z == 0)";
runTest(ImmutableMap.of("cel.example.y", ImmutableMap.of("z", 1)));

clearAllDeclarations();
declareVariable("y.z", SimpleType.INT);
container = CelContainer.ofName("y");
source = "[{'z': 0}].exists(y, y.z == 0 && .y.z == 1)";
runTest(ImmutableMap.of("y.z", 1));

clearAllDeclarations();
declareVariable("x", SimpleType.INT);
source = "[0].exists(x, x == 0 && .x == 1)";
runTest(ImmutableMap.of("x", 1));

source = "[0].exists(x, [x+1].exists(x, x == .x))";
runTest(ImmutableMap.of("x", 1));
}

@Test
Expand Down
Loading