Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 18, 2026
Merged

Properly establish cross dependenies across maven artifacts #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions .github/workflows/cross_artifact_dependencies_check.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
"//publish:cel"
"//publish:cel_common"
"//publish:cel_compiler"
"//publish:cel_runtime"
"//publish:cel_protobuf"
"//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
for target in "${TARGETS[@]}"; do
# Locate the jar
jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

if [[ -z "$jar_path" ]]; then
echo "Error: Could not find -project.jar for target $target" >&2
exit 1
fi

# Fix relative paths if running from a subdir.
if [[ ! -f "$jar_path" ]]; then
if [[ -f "../../$jar_path" ]]; then
jar_path="../../$jar_path"
else
echo "Error: File not found at $jar_path" >&2
exit 1
fi
fi

echo "Inspecting: $target" >&2

# Extract classes and append the target name to the end of the line
# Format: dev/cel/expr/Expr.class //publish:cel_compiler
jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
done
) | awk '
# $1 is the Class Name, $2 is the Target Name
seen[$1] {
print "❌ DUPLICATE FOUND: " $1
print " Present in: " seen[$1]
print " And in: " $2
dupe=1
next
}
{ seen[$1] = $2 }

END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
echo "⛔ Failure: Duplicate classes detected."
else
echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE

6 changes: 5 additions & 1 deletion .github/workflows/unwanted_deps.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0
53 changes: 46 additions & 7 deletions .github/workflows/workflow.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
cancel-in-progress: true

jobs:
Static-Checks:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
- run: echo "🐧 Job is running on a ${{ runner.os }} server!"
- run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
- name: Check out repository code
uses: actions/checkout@v6
- name: Setup Bazel
uses: bazel-contrib/setup-bazel@0.18.0
with:
# Avoid downloading Bazel every time.
bazelisk-cache: true
# Store build cache per workflow.
disk-cache: ${{ github.workflow }}
# Share repository cache between workflows.
repository-cache: true
- name: Unwanted Dependencies
run: .github/workflows/unwanted_deps.sh
- name: Cross-artifact Duplicate Classes Check
run: .github/workflows/cross_artifact_dependencies_check.sh
- run: echo "🍏 This job's status is ${{ job.status }}."
Bazel-Tests:
runs-on: ubuntu-latest
timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
- name: Check out repository code
uses: actions/checkout@v6
- name: Setup Bazel
uses: bazel-contrib/setup-bazel@0.14.0
uses: bazel-contrib/setup-bazel@0.18.0
with:
# Avoid downloading Bazel every time.
bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
# Exclude codelab exercises as they are intentionally made to fail
# Exclude maven conformance tests. They are only executed when there's version change.
run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
- run: echo "🍏 This job's status is ${{ job.status }}."

# -- Start of Maven Conformance Tests (Ran only when there's version changes) --
- name: Get changed file
# -- Start of Maven Conformance Tests (Ran only when there's version changes) --
Maven-Conformance:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
- run: echo "🐧 Job is running on a ${{ runner.os }} server!"
- run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
- name: Check out repository code
uses: actions/checkout@v6
- name: Get changed files
id: changed_file
uses: tj-actions/changed-files@v46
with:
files: publish/cel_version.bzl
- name: Setup Bazel
if: steps.changed_file.outputs.any_changed == 'true'
uses: bazel-contrib/setup-bazel@0.18.0
with:
# Avoid downloading Bazel every time.
bazelisk-cache: true
# Store build cache per workflow.
disk-cache: ${{ github.workflow }}
# Share repository cache between workflows.
repository-cache: true
- name: Verify Version Consistency
if: steps.changed_file.outputs.any_changed == 'true'
run: |
Expand All@@ -72,8 +115,4 @@ jobs:
- name: Run Conformance Maven Test on Version Change
if: steps.changed_file.outputs.any_changed == 'true'
run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
# -- End of Maven Conformance Tests --

- name: Unwanted Dependencies
run: .github/workflows/unwanted_deps.sh
- run: echo "🍏 This job's status is ${{ job.status }}."
9 changes: 6 additions & 3 deletions common/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
name = "cel_source_helper",
visibility = ["//:internal"],
exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
name = "cel_ast",
exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
visibility = [
"//:internal",
# TODO: Remove references to the following clients
"//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
"//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
"//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
],
exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down
5 changes: 5 additions & 0 deletions common/internal/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
name = "code_point_stream",
exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
name = "comparison_functions",
exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down
29 changes: 26 additions & 3 deletions common/src/main/java/dev/cel/common/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
"CelSourceHelper.java",
"Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
tags = [
],
deps = [
":cel_source_helper",
":source",
":source_location",
"//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
tags = [
],
deps = [
":cel_source_helper_android",
":source_android",
":source_location_android",
"//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
],
)

java_library(
name = "cel_source_helper",
srcs = ["CelSourceHelper.java"],
tags = [
],
deps = [
":source_location",
"//common/annotations",
"//common/internal",
"@maven//:com_google_guava_guava",
],
)

cel_android_library(
name = "cel_source_helper_android",
srcs = ["CelSourceHelper.java"],
deps = [
":source_location_android",
"//common/annotations",
"//common/internal:internal_android",
"@maven_android//:com_google_guava_guava",
],
)

java_library(
name = "cel_ast",
srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
tags = [
],
deps = [
":source_location",
"//common/annotations",
"//common/internal",
"@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
srcs = SOURCE_SOURCES,
visibility = ["//visibility:private"],
deps = [
":source_location_android",
"//common/annotations",
"//common/internal:internal_android",
"@maven_android//:com_google_guava_guava",
Expand Down
1 change: 1 addition & 0 deletions common/src/main/java/dev/cel/common/formats/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
],
deps = [
"//:auto_value",
"//common:cel_source_helper",
"//common:source",
"//common:source_location",
"//common/internal",
Expand Down
17 changes: 14 additions & 3 deletions common/src/main/java/dev/cel/common/internal/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
],
default_visibility = [
"//common/internal:__pkg__",
"//publish:__pkg__",
],
)

# keep sorted
INTERNAL_SOURCES = [
"BasicCodePointArray.java",
"CelCodePointArray.java",
"CodePointStream.java",
"Constants.java",
"EmptyCodePointArray.java",
"Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
"DefaultDescriptorPool.java",
]

java_library(
name = "code_point_stream",
srcs = ["CodePointStream.java"],
tags = [
],
deps = [
":internal",
"//common/annotations",
"@maven//:com_google_guava_guava",
"@maven//:org_antlr_antlr4_runtime",
],
)

java_library(
name = "internal",
srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:com_google_guava_guava",
"@maven//:com_google_protobuf_protobuf_java",
"@maven//:org_antlr_antlr4_runtime",
],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
"//common/values:values_android",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:com_google_guava_guava",
"@maven//:org_antlr_antlr4_runtime",
"@maven_android//:com_google_guava_guava",
"@maven_android//:com_google_protobuf_protobuf_javalite",
],
Expand Down
1 change: 1 addition & 0 deletions common/src/main/java/dev/cel/common/types/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
],
default_visibility = [
"//common/types:__pkg__",
"//publish:__pkg__",
],
)

Expand Down
1 change: 1 addition & 0 deletions common/src/main/java/dev/cel/common/values/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
],
default_visibility = [
"//common/values:__pkg__",
"//publish:__pkg__",
],
)

Expand Down
1 change: 1 addition & 0 deletions common/src/test/java/dev/cel/common/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
"//common:source_location",
"//common/ast",
"//common/internal",
"//common/internal:code_point_stream",
"//common/types",
"//common/types:cel_proto_types",
"//common/types:cel_v1alpha1_types",
Expand Down
1 change: 1 addition & 0 deletions parser/src/main/java/dev/cel/parser/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
"//common/annotations",
"//common/ast",
"//common/internal",
"//common/internal:code_point_stream",
"//common/internal:env_visitor",
"//parser:cel_g4_visitors",
"@maven//:com_google_errorprone_error_prone_annotations",
Expand Down
1 change: 1 addition & 0 deletions policy/src/main/java/dev/cel/policy/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
],
deps = [
"//:auto_value",
"//common:cel_source_helper",
"//common:source",
"//common:source_location",
"//common/internal",
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Properly establish cross dependenies across maven artifacts#954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Feb 18, 2026
 Merged


Properly establish cross dependenies across maven artifacts
#954
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


85 changes: 85 additions & 0 deletions
.github/workflows/cross_artifact_dependencies_check.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
#!/bin/bash
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o pipefail

TARGETS=(
 "//publish:cel"
 "//publish:cel_common"
 "//publish:cel_compiler"
 "//publish:cel_runtime"
 "//publish:cel_protobuf"
 "//publish:cel_v1alpha1"
)

echo "------------------------------------------------"
echo "Checking for duplicates..."
echo "------------------------------------------------"

JDK8_FLAGS="--java_language_version=8 --java_runtime_version=8"
bazel build $JDK8_FLAGS "${TARGETS[@]}" || { echo "Bazel build failed"; exit 1; }

(
 for target in "${TARGETS[@]}"; do
 # Locate the jar
 jar_path=$(bazel cquery "$target" --output=files 2>/dev/null | grep '\-project.jar$')

 if [[ -z "$jar_path" ]]; then
 echo "Error: Could not find -project.jar for target $target" >&2
 exit 1
 fi

 # Fix relative paths if running from a subdir.
 if [[ ! -f "$jar_path" ]]; then
 if [[ -f "../../$jar_path" ]]; then
 jar_path="../../$jar_path"
 else
 echo "Error: File not found at $jar_path" >&2
 exit 1
 fi
 fi

 echo "Inspecting: $target" >&2

 # Extract classes and append the target name to the end of the line
 # Format: dev/cel/expr/Expr.class //publish:cel_compiler
 jar tf "$jar_path" | grep "\.class$" | awk -v tgt="$target" '{print $0, tgt}'
 done
) | awk '
 # $1 is the Class Name, $2 is the Target Name
 seen[$1] {
 print "❌ DUPLICATE FOUND: " $1
 print " Present in: " seen[$1]
 print " And in: " $2
 dupe=1
 next
 }
 { seen[$1] = $2 }

 END { if (dupe) exit 2 }
'

EXIT_CODE=$?

if [ $EXIT_CODE -eq 0 ]; then
 echo "✅ Success: No duplicate classes found."
elif [ $EXIT_CODE -eq 2 ]; then
 echo "⛔ Failure: Duplicate classes detected."
else
 echo "💥 Error: An unexpected error occurred (e.g., missing jar files). Exit Code: $EXIT_CODE"
fi

exit $EXIT_CODE


6 changes: 5 additions & 1 deletion
.github/workflows/unwanted_deps.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,10 +36,14 @@ checkUnwantedDeps '//publish:cel_runtime' '@cel_spec'
checkUnwantedDeps '//publish:cel_runtime' 'protobuf_java_util'
checkUnwantedDeps '//publish:cel' 'protobuf_java_util'

# cel_runtime shouldn't depend on antlr
checkUnwantedDeps '//publish:cel_runtime' '@maven//:org_antlr_antlr4_runtime'

# cel_runtime shouldn't depend on the protobuf_lite runtime
checkUnwantedDeps '//publish:cel_runtime' '@maven_android//:com_google_protobuf_protobuf_javalite'
checkUnwantedDeps '//publish:cel' '@maven_android//:com_google_protobuf_protobuf_javalite'

# cel_runtime_android shouldn't depend on the full protobuf runtime
# cel_runtime_android shouldn't depend on the full protobuf runtime or antlr
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:com_google_protobuf_protobuf_java'
checkUnwantedDeps '//publish:cel_runtime_android' '@maven//:org_antlr_antlr4_runtime'
exit 0

53 changes: 46 additions & 7 deletions
.github/workflows/workflow.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,29 @@ concurrency:
 cancel-in-progress: true

jobs:
 Static-Checks:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - name: Cross-artifact Duplicate Classes Check
 run: .github/workflows/cross_artifact_dependencies_check.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."
 Bazel-Tests:
 runs-on: ubuntu-latest
 timeout-minutes: 30
Expand All@@ -25,7 +48,7 @@ jobs:
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Setup Bazel
 uses: bazel-contrib/setup-bazel@0.14.0
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
Expand All@@ -41,13 +64,33 @@ jobs:
 # Exclude codelab exercises as they are intentionally made to fail
 # Exclude maven conformance tests. They are only executed when there's version change.
 run: bazelisk test ... --deleted_packages=//codelab/src/test/codelab --test_output=errors --test_tag_filters=-conformance_maven --build_tag_filters=-conformance_maven
 - run: echo "🍏 This job's status is ${{ job.status }}."

 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 - name: Get changed file
 # -- Start of Maven Conformance Tests (Ran only when there's version changes) --
 Maven-Conformance:
 runs-on: ubuntu-latest
 timeout-minutes: 30
 steps:
 - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
 - run: echo "🐧 Job is running on a ${{ runner.os }} server!"
 - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
 - name: Check out repository code
 uses: actions/checkout@v6
 - name: Get changed files
 id: changed_file
 uses: tj-actions/changed-files@v46
 with:
 files: publish/cel_version.bzl
 - name: Setup Bazel
 if: steps.changed_file.outputs.any_changed == 'true'
 uses: bazel-contrib/setup-bazel@0.18.0
 with:
 # Avoid downloading Bazel every time.
 bazelisk-cache: true
 # Store build cache per workflow.
 disk-cache: ${{ github.workflow }}
 # Share repository cache between workflows.
 repository-cache: true
 - name: Verify Version Consistency
 if: steps.changed_file.outputs.any_changed == 'true'
 run: |
Expand All@@ -72,8 +115,4 @@ jobs:
 - name: Run Conformance Maven Test on Version Change
 if: steps.changed_file.outputs.any_changed == 'true'
 run: bazelisk test //conformance/src/test/java/dev/cel/conformance:conformance_maven --test_output=errors
 # -- End of Maven Conformance Tests --

 - name: Unwanted Dependencies
 run: .github/workflows/unwanted_deps.sh
 - run: echo "🍏 This job's status is ${{ job.status }}."

9 changes: 6 additions & 3 deletions
common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,12 @@ cel_android_library(
 exports = ["//common/src/main/java/dev/cel/common:cel_source_android"],
)

java_library(
 name = "cel_source_helper",
 visibility = ["//:internal"],
 exports = ["//common/src/main/java/dev/cel/common:cel_source_helper"],
)

java_library(
 name = "cel_ast",
 exports = ["//common/src/main/java/dev/cel/common:cel_ast"],
Expand DownExpand Up@@ -108,9 +114,6 @@ java_library(
 visibility = [
 "//:internal",
 # TODO: Remove references to the following clients
 "//java/com/google/abuse/admin/notebook/compiler/checkedtypes:__pkg__",
 "//java/com/google/paymentfraud/v2/util/featurereplay/common/risklogrecordio:__pkg__",
 "//java/com/google/payments/consumer/growth/treatmentconfig/management/backend/service/config/utils:__pkg__",
 ],
 exports = ["//common/src/main/java/dev/cel/common:cel_descriptor_util"],
)
Expand Down

5 changes: 5 additions & 0 deletions
common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,11 @@ java_library(
 exports = ["//common/src/main/java/dev/cel/common/internal"],
)

java_library(
 name = "code_point_stream",
 exports = ["//common/src/main/java/dev/cel/common/internal:code_point_stream"],
)

java_library(
 name = "comparison_functions",
 exports = ["//common/src/main/java/dev/cel/common/internal:comparison_functions"],
Expand Down

29 changes: 26 additions & 3 deletions
common/src/main/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,6 @@ COMPILER_COMMON_SOURCES = [

# keep sorted
SOURCE_SOURCES = [
 "CelSourceHelper.java",
 "Source.java",
]

Expand DownExpand Up@@ -234,6 +233,7 @@ java_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper",
 ":source",
 ":source_location",
 "//:auto_value",
Expand All@@ -250,6 +250,7 @@ cel_android_library(
 tags = [
 ],
 deps = [
 ":cel_source_helper_android",
 ":source_android",
 ":source_location_android",
 "//:auto_value",
Expand All@@ -260,6 +261,30 @@ cel_android_library(
 ],
)

java_library(
 name = "cel_source_helper",
 srcs = ["CelSourceHelper.java"],
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "cel_source_helper_android",
 srcs = ["CelSourceHelper.java"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "cel_ast",
 srcs = ["CelAbstractSyntaxTree.java"],
Expand DownExpand Up@@ -300,7 +325,6 @@ java_library(
 tags = [
 ],
 deps = [
 ":source_location",
 "//common/annotations",
 "//common/internal",
 "@maven//:com_google_guava_guava",
Expand All@@ -312,7 +336,6 @@ cel_android_library(
 srcs = SOURCE_SOURCES,
 visibility = ["//visibility:private"],
 deps = [
 ":source_location_android",
 "//common/annotations",
 "//common/internal:internal_android",
 "@maven_android//:com_google_guava_guava",
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/formats/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,6 +71,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down

17 changes: 14 additions & 3 deletions
common/src/main/java/dev/cel/common/internal/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,14 +7,14 @@ package(
 ],
 default_visibility = [
 "//common/internal:__pkg__",
 "//publish:__pkg__",
 ],
)

# keep sorted
INTERNAL_SOURCES = [
 "BasicCodePointArray.java",
 "CelCodePointArray.java",
 "CodePointStream.java",
 "Constants.java",
 "EmptyCodePointArray.java",
 "Latin1CodePointArray.java",
Expand All@@ -34,6 +34,19 @@ CEL_DESCRIPTOR_POOL_SOURCES = [
 "DefaultDescriptorPool.java",
]

java_library(
 name = "code_point_stream",
 srcs = ["CodePointStream.java"],
 tags = [
 ],
 deps = [
 ":internal",
 "//common/annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

java_library(
 name = "internal",
 srcs = INTERNAL_SOURCES,
Expand All@@ -48,7 +61,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_antlr_antlr4_runtime",
 ],
)

Expand All@@ -65,7 +77,6 @@ cel_android_library(
 "//common/values:values_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_antlr_antlr4_runtime",
 "@maven_android//:com_google_guava_guava",
 "@maven_android//:com_google_protobuf_protobuf_javalite",
 ],
Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/types/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/types:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/main/java/dev/cel/common/values/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ package(
 ],
 default_visibility = [
 "//common/values:__pkg__",
 "//publish:__pkg__",
 ],
)

Expand Down

1 change: 1 addition & 0 deletions
common/src/test/java/dev/cel/common/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ java_library(
 "//common:source_location",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/types",
 "//common/types:cel_proto_types",
 "//common/types:cel_v1alpha1_types",
Expand Down

1 change: 1 addition & 0 deletions
parser/src/main/java/dev/cel/parser/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@ java_library(
 "//common/annotations",
 "//common/ast",
 "//common/internal",
 "//common/internal:code_point_stream",
 "//common/internal:env_visitor",
 "//parser:cel_g4_visitors",
 "@maven//:com_google_errorprone_error_prone_annotations",
Expand Down

1 change: 1 addition & 0 deletions
policy/src/main/java/dev/cel/policy/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ java_library(
 ],
 deps = [
 "//:auto_value",
 "//common:cel_source_helper",
 "//common:source",
 "//common:source_location",
 "//common/internal",
Expand Down
Loading
Loading