Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 17, 2026
Merged

Support partial evaluation via unknowns in planner #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extensions/src/test/java/dev/cel/extensions/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
"//runtime:interpreter_util",
"//runtime:lite_runtime",
"//runtime:lite_runtime_factory",
"//runtime:partial_vars",
"//runtime:unknown_attributes",
"@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
"@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
"@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down
49 changes: 34 additions & 15 deletions extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
@TestParameters("{source: '{?x: x}'}")
public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
throws Exception {
if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
// TODO: Uncomment once unknowns is implemented
return;
}
Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
CelAbstractSyntaxTree ast = compile(cel, source);

Object result = cel.createProgram(ast).eval();
Object result =
cel.createProgram(ast)
.eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

assertThat(InterpreterUtil.isUnknown(result)).isTrue();
}
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

@Test
public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
// TODO: Uncomment once unknowns is implemented
return;
}
Cel cel =
newCelBuilder()
.addVar("x", OptionalType.create(SimpleType.INT))
.setResultType(ListType.create(SimpleType.INT))
.build();
CelAbstractSyntaxTree ast = compile(cel, "[?x]");

Object result = cel.createProgram(ast).eval();
Object result =
cel.createProgram(ast)
.eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

assertThat(InterpreterUtil.isUnknown(result)).isTrue();
}
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
assertThat(result).isEqualTo(Optional.empty());
}

@Test
public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
if (testMode.equals(TestMode.LEGACY_CHECKED)) {
// This case is not possible to setup for legacy runtime
return;
}

Cel cel =
newCelBuilder()
.addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
.build();
CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

Object result =
cel.createProgram(ast)
.eval(
PartialVars.of(
ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

assertThat(InterpreterUtil.isUnknown(result)).isTrue();
}

@Test
// LHS
@TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
@TestParameters("{expression: 'optional.none().orValue(optx)'}")
public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
throws Exception {
if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
// TODO: Uncomment once unknowns is implemented
return;
}
Cel cel =
newCelBuilder()
.addVar("optx", OptionalType.create(SimpleType.INT))
.addVar("x", SimpleType.INT)
.build();
CelAbstractSyntaxTree ast = compile(cel, expression);

Object result = cel.createProgram(ast).eval();
Object result =
cel.createProgram(ast)
.eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

assertThat(InterpreterUtil.isUnknown(result)).isTrue();
}
Expand Down
14 changes: 14 additions & 0 deletions runtime/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
"//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
],
)

java_library(
name = "accumulated_unknowns",
visibility = ["//:internal"],
exports = [
"//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
],
)

java_library(
name = "partial_vars",
visibility = ["//:internal"],
exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)
25 changes: 22 additions & 3 deletions runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
* An internal representation used for fast accumulation of unknown expr IDs and attributes. For
* safety, this object should never be returned as an evaluated result and instead be adapted into
* an immutable CelUnknownSet.
*
* <p>CEL Library Internals. Do Not Use.
*/
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
private final Set<Long> exprIds;
private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
return attributes;
}

/**
* Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
* accumulator.
*/
public static @Nullable AccumulatedUnknowns maybeMerge(
@Nullable AccumulatedUnknowns accumulator, Object newValue) {
if (newValue instanceof AccumulatedUnknowns) {
AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
}
return accumulator;
}

@CanIgnoreReturnValue
AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
enforceMaxAttributeSize(this.attributes, arg.attributes);
this.exprIds.addAll(arg.exprIds);
this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
return create(ids, new ArrayList<>());
}

static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
public static AccumulatedUnknowns create(
Collection<Long> exprIds, Collection<CelAttribute> attributes) {
return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
}

Expand Down
45 changes: 42 additions & 3 deletions runtime/src/main/java/dev/cel/runtime/BUILD.bazel
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
":evaluation_listener",
":function_binding",
":function_resolver",
":partial_vars",
":program",
":proto_message_runtime_equality",
":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
":function_resolver",
":interpretable",
":interpreter",
":partial_vars",
":program",
":proto_message_activation_factory",
":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:com_google_guava_guava",
"@maven//:com_google_protobuf_protobuf_java",
"@maven//:org_jspecify_jspecify",
],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
":evaluation_exception",
":function_resolver",
":interpretable",
":partial_vars",
":program",
":variable_resolver",
"//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
":evaluation_exception",
":function_resolver_android",
":interpretable_android",
":partial_vars_android",
":program_android",
":variable_resolver",
"//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
":unknown_attributes",
"//common/annotations",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:com_google_guava_guava",
"@maven//:org_jspecify_jspecify",
],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
"//common/annotations",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:org_jspecify_jspecify",
"@maven_android//:com_google_guava_guava",
],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
name = "accumulated_unknowns",
srcs = ["AccumulatedUnknowns.java"],
visibility = ["//visibility:private"],
tags = [
],
deps = [
":unknown_attributes",
"//common/annotations",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:org_jspecify_jspecify",
],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
visibility = ["//visibility:private"],
deps = [
":unknown_attributes_android",
"//common/annotations",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:org_jspecify_jspecify",
],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
],
)

java_library(
name = "partial_vars",
srcs = ["PartialVars.java"],
tags = [
],
deps = [
":variable_resolver",
"//:auto_value",
"//runtime:unknown_attributes",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven//:com_google_guava_guava",
],
)

cel_android_library(
name = "partial_vars_android",
srcs = ["PartialVars.java"],
tags = [
],
deps = [
":variable_resolver",
"//:auto_value",
"//runtime:unknown_attributes_android",
"@maven//:com_google_errorprone_error_prone_annotations",
"@maven_android//:com_google_guava_guava",
],
)

java_library(
name = "program",
srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
deps = [
":evaluation_exception",
":function_resolver",
":partial_vars",
":variable_resolver",
"@maven//:com_google_errorprone_error_prone_annotations",
],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
deps = [
":evaluation_exception",
":function_resolver_android",
":partial_vars_android",
":variable_resolver",
"//:auto_value",
"@maven//:com_google_errorprone_error_prone_annotations",
],
)
Expand Down
5 changes: 5 additions & 0 deletions runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
return program.eval(resolver, lateBoundFunctionResolver);
}

@Override
public Object eval(PartialVars partialVars) throws CelEvaluationException {
return program.eval(partialVars);
}

@Override
public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down
2 changes: 1 addition & 1 deletion runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
}

static CelUnknownSet create(
public static CelUnknownSet create(
ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
}
Expand Down
17 changes: 14 additions & 3 deletions runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
return obj instanceof CelUnknownSet;
}

static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
return obj instanceof AccumulatedUnknowns;
}

/** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
if (!(val instanceof CelUnknownSet)) {
return val;
}

return adaptToAccumulatedUnknowns((CelUnknownSet) val);
}

static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
}

public static Object maybeAdaptToCelUnknownSet(Object val) {
if (!(val instanceof AccumulatedUnknowns)) {
return val;
}

AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
return CelUnknownSet.create(
ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
}

/**
* Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
* an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Support partial evaluation via unknowns in planner#982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

copybara-service
merged 1 commit into

from

Mar 17, 2026
 Merged


Support partial evaluation via unknowns in planner
#982
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
extensions/src/test/java/dev/cel/extensions/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,8 @@ java_library(
 "//runtime:interpreter_util",
 "//runtime:lite_runtime",
 "//runtime:lite_runtime_factory",
 "//runtime:partial_vars",
 "//runtime:unknown_attributes",
 "@cel_spec//proto/cel/expr/conformance/proto2:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/proto3:test_all_types_java_proto",
 "@cel_spec//proto/cel/expr/conformance/test:simple_java_proto",
Expand Down

49 changes: 34 additions & 15 deletions
extensions/src/test/java/dev/cel/extensions/CelOptionalLibraryTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -49,10 +49,12 @@
import dev.cel.expr.conformance.proto3.TestAllTypes.NestedMessage;
import dev.cel.parser.CelMacro;
import dev.cel.parser.CelStandardMacro;
import dev.cel.runtime.CelAttributePattern;
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelFunctionBinding;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.InterpreterUtil;
import dev.cel.runtime.PartialVars;
import java.time.Duration;
import java.time.Instant;
import java.util.List;
Expand DownExpand Up@@ -897,14 +899,12 @@ public void optionalIndex_onMap_returnsOptionalValue() throws Exception {
 @TestParameters("{source: '{?x: x}'}")
 public void optionalIndex_onMapWithUnknownInput_returnsUnknownResult(String source)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel = newCelBuilder().addVar("x", OptionalType.create(SimpleType.INT)).build();
 CelAbstractSyntaxTree ast = compile(cel, source);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand DownExpand Up@@ -987,18 +987,16 @@ public void optionalIndex_onOptionalList_returnsOptionalValue() throws Exception

 @Test
 public void optionalIndex_onListWithUnknownInput_returnsUnknownResult() throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("x", OptionalType.create(SimpleType.INT))
 .setResultType(ListType.create(SimpleType.INT))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "[?x]");

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("x")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand All@@ -1017,6 +1015,29 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 assertThat(result).isEqualTo(Optional.empty());
 }

 @Test
 public void optionalFieldSelect_fieldMarkedUnknown_returnsUnknownSet() throws Exception {
 if (testMode.equals(TestMode.LEGACY_CHECKED)) {
 // This case is not possible to setup for legacy runtime
 return;
 }

 Cel cel =
 newCelBuilder()
 .addVar("msg", StructTypeReference.create(TestAllTypes.getDescriptor().getFullName()))
 .build();
 CelAbstractSyntaxTree ast = compile(cel, "msg.?single_int32");

 Object result =
 cel.createProgram(ast)
 .eval(
 PartialVars.of(
 ImmutableMap.of("msg", TestAllTypes.newBuilder().setSingleInt32(42).build()),
 CelAttributePattern.fromQualifiedIdentifier("msg.single_int32")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }

 @Test
 // LHS
 @TestParameters("{expression: 'optx.or(optional.of(1))'}")
Expand All@@ -1026,18 +1047,16 @@ public void traditionalIndex_onOptionalList_returnsOptionalEmpty() throws Except
 @TestParameters("{expression: 'optional.none().orValue(optx)'}")
 public void optionalChainedFunctions_lhsIsUnknown_returnsUnknown(String expression)
 throws Exception {
 if (testMode.equals(TestMode.PLANNER_CHECKED) || testMode.equals(TestMode.PLANNER_PARSE_ONLY)) {
 // TODO: Uncomment once unknowns is implemented
 return;
 }
 Cel cel =
 newCelBuilder()
 .addVar("optx", OptionalType.create(SimpleType.INT))
 .addVar("x", SimpleType.INT)
 .build();
 CelAbstractSyntaxTree ast = compile(cel, expression);

 Object result = cel.createProgram(ast).eval();
 Object result =
 cel.createProgram(ast)
 .eval(PartialVars.of(CelAttributePattern.fromQualifiedIdentifier("optx")));

 assertThat(InterpreterUtil.isUnknown(result)).isTrue();
 }
Expand Down

14 changes: 14 additions & 0 deletions
runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -351,3 +351,17 @@ java_library(
 "//runtime/src/main/java/dev/cel/runtime:runtime_planner_impl",
 ],
)

java_library(
 name = "accumulated_unknowns",
 visibility = ["//:internal"],
 exports = [
 "//runtime/src/main/java/dev/cel/runtime:accumulated_unknowns",
 ],
)

java_library(
 name = "partial_vars",
 visibility = ["//:internal"],
 exports = ["//runtime/src/main/java/dev/cel/runtime:partial_vars"],
)

25 changes: 22 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/AccumulatedUnknowns.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,18 +15,23 @@
package dev.cel.runtime;

import com.google.errorprone.annotations.CanIgnoreReturnValue;
import dev.cel.common.annotations.Internal;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.jspecify.annotations.Nullable;

/**
 * An internal representation used for fast accumulation of unknown expr IDs and attributes. For
 * safety, this object should never be returned as an evaluated result and instead be adapted into
 * an immutable CelUnknownSet.
 *
 * <p>CEL Library Internals. Do Not Use.
 */
final class AccumulatedUnknowns {
@Internal
public final class AccumulatedUnknowns {
 private static final int MAX_UNKNOWN_ATTRIBUTE_SIZE = 500_000;
 private final Set<Long> exprIds;
 private final Set<CelAttribute> attributes;
Expand All@@ -39,8 +44,21 @@ Set<CelAttribute> attributes() {
 return attributes;
 }

 /**
 * Evaluates if the right hand side is an accumulated unknown, and if so, merges it into the
 * accumulator.
 */
 public static @Nullable AccumulatedUnknowns maybeMerge(
 @Nullable AccumulatedUnknowns accumulator, Object newValue) {
 if (newValue instanceof AccumulatedUnknowns) {
 AccumulatedUnknowns newUnknowns = (AccumulatedUnknowns) newValue;
 return accumulator == null ? newUnknowns : accumulator.merge(newUnknowns);
 }
 return accumulator;
 }

 @CanIgnoreReturnValue
 AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
public AccumulatedUnknowns merge(AccumulatedUnknowns arg) {
 enforceMaxAttributeSize(this.attributes, arg.attributes);
 this.exprIds.addAll(arg.exprIds);
 this.attributes.addAll(arg.attributes);
Expand All@@ -55,7 +73,8 @@ static AccumulatedUnknowns create(Collection<Long> ids) {
 return create(ids, new ArrayList<>());
 }

 static AccumulatedUnknowns create(Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 public static AccumulatedUnknowns create(
 Collection<Long> exprIds, Collection<CelAttribute> attributes) {
 return new AccumulatedUnknowns(new HashSet<>(exprIds), new HashSet<>(attributes));
 }

Expand Down

45 changes: 42 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/BUILD.bazel

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -826,6 +826,7 @@ java_library(
 ":evaluation_listener",
 ":function_binding",
 ":function_resolver",
 ":partial_vars",
 ":program",
 ":proto_message_runtime_equality",
 ":runtime",
Expand DownExpand Up@@ -938,6 +939,7 @@ java_library(
 ":function_resolver",
 ":interpretable",
 ":interpreter",
 ":partial_vars",
 ":program",
 ":proto_message_activation_factory",
 ":runtime_equality",
Expand All@@ -955,7 +957,6 @@ java_library(
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:com_google_protobuf_protobuf_java",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1014,6 +1015,7 @@ java_library(
 ":evaluation_exception",
 ":function_resolver",
 ":interpretable",
 ":partial_vars",
 ":program",
 ":variable_resolver",
 "//:auto_value",
Expand All@@ -1029,6 +1031,7 @@ cel_android_library(
 ":evaluation_exception",
 ":function_resolver_android",
 ":interpretable_android",
 ":partial_vars_android",
 ":program_android",
 ":variable_resolver",
 "//:auto_value",
Expand DownExpand Up@@ -1199,6 +1202,7 @@ java_library(
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 "@maven//:org_jspecify_jspecify",
 ],
)
Expand All@@ -1214,6 +1218,7 @@ cel_android_library(
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 "@maven_android//:com_google_guava_guava",
 ],
)

Expand DownExpand Up@@ -1273,10 +1278,13 @@ java_library(
java_library(
 name = "accumulated_unknowns",
 srcs = ["AccumulatedUnknowns.java"],
 visibility = ["//visibility:private"],
 tags = [
 ],
 deps = [
 ":unknown_attributes",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand All@@ -1286,7 +1294,9 @@ cel_android_library(
 visibility = ["//visibility:private"],
 deps = [
 ":unknown_attributes_android",
 "//common/annotations",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:org_jspecify_jspecify",
 ],
)

Expand DownExpand Up@@ -1318,6 +1328,34 @@ cel_android_library(
 ],
)

java_library(
 name = "partial_vars",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven//:com_google_guava_guava",
 ],
)

cel_android_library(
 name = "partial_vars_android",
 srcs = ["PartialVars.java"],
 tags = [
 ],
 deps = [
 ":variable_resolver",
 "//:auto_value",
 "//runtime:unknown_attributes_android",
 "@maven//:com_google_errorprone_error_prone_annotations",
 "@maven_android//:com_google_guava_guava",
 ],
)

java_library(
 name = "program",
 srcs = ["Program.java"],
Expand All@@ -1326,6 +1364,7 @@ java_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver",
 ":partial_vars",
 ":variable_resolver",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
Expand All@@ -1339,8 +1378,8 @@ cel_android_library(
 deps = [
 ":evaluation_exception",
 ":function_resolver_android",
 ":partial_vars_android",
 ":variable_resolver",
 "//:auto_value",
 "@maven//:com_google_errorprone_error_prone_annotations",
 ],
)
Expand Down

5 changes: 5 additions & 0 deletions
runtime/src/main/java/dev/cel/runtime/CelRuntimeImpl.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,6 +134,11 @@ public Object eval(
 return program.eval(resolver, lateBoundFunctionResolver);
 }

 @Override
 public Object eval(PartialVars partialVars) throws CelEvaluationException {
 return program.eval(partialVars);
 }

 @Override
 public Object trace(CelEvaluationListener listener) throws CelEvaluationException {
 throw new UnsupportedOperationException("Trace is not yet supported.");
Expand Down

2 changes: 1 addition & 1 deletion
runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ static CelUnknownSet create(Iterable<Long> unknownExprIds) {
 return create(ImmutableSet.of(), ImmutableSet.copyOf(unknownExprIds));
 }

 static CelUnknownSet create(
public static CelUnknownSet create(
 ImmutableSet<CelAttribute> attributes, ImmutableSet<Long> unknownExprIds) {
 return new AutoValue_CelUnknownSet(attributes, unknownExprIds);
 }
Expand Down

17 changes: 14 additions & 3 deletions
runtime/src/main/java/dev/cel/runtime/InterpreterUtil.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@

package dev.cel.runtime;

import com.google.common.collect.ImmutableSet;
import com.google.errorprone.annotations.CheckReturnValue;
import dev.cel.common.annotations.Internal;
import org.jspecify.annotations.Nullable;
Expand DownExpand Up@@ -55,23 +56,33 @@ public static boolean isUnknown(Object obj) {
 return obj instanceof CelUnknownSet;
 }

 static boolean isAccumulatedUnknowns(Object obj) {
public static boolean isAccumulatedUnknowns(Object obj) {
 return obj instanceof AccumulatedUnknowns;
 }

 /** If the argument is {@link CelUnknownSet}, adapts it into {@link AccumulatedUnknowns} */
 static Object maybeAdaptToAccumulatedUnknowns(Object val) {
public static Object maybeAdaptToAccumulatedUnknowns(Object val) {
 if (!(val instanceof CelUnknownSet)) {
 return val;
 }

 return adaptToAccumulatedUnknowns((CelUnknownSet) val);
 }

 static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
public static AccumulatedUnknowns adaptToAccumulatedUnknowns(CelUnknownSet unknowns) {
 return AccumulatedUnknowns.create(unknowns.unknownExprIds(), unknowns.attributes());
 }

 public static Object maybeAdaptToCelUnknownSet(Object val) {
 if (!(val instanceof AccumulatedUnknowns)) {
 return val;
 }

 AccumulatedUnknowns unknowns = (AccumulatedUnknowns) val;
 return CelUnknownSet.create(
 ImmutableSet.copyOf(unknowns.attributes()), ImmutableSet.copyOf(unknowns.exprIds()));
 }

 /**
 * Enforces strictness on both lhs/rhs arguments from logical operators (i.e: intentionally throws
 * an appropriate exception when {@link Throwable} is encountered as part of evaluated result.
Expand Down
Loading
Loading