Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,8 +119,7 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand DownExpand Up@@ -148,8 +147,7 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format and strings.quote.
"string_ext/quote",
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,6 +137,17 @@ public enum Function {
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_lower_ascii", String.class, Ascii::toLowerCase)),
QUOTE(
CelFunctionDecl.newFunctionDeclaration(
"strings.quote",
CelOverloadDecl.newGlobalOverload(
"strings_quote",
"Takes the given string and makes it safe to print (without any formatting"
+ " due to escape sequences). If any invalid UTF-8 characters are"
+ " encountered, they are replaced with \\uFFFD.",
SimpleType.STRING,
ImmutableList.of(SimpleType.STRING))),
CelFunctionBinding.from("strings_quote", String.class, CelStringExtensions::quote)),
REPLACE(
CelFunctionDecl.newFunctionDeclaration(
"replace",
Expand DownExpand Up@@ -164,6 +175,16 @@ public enum Function {
"string_replace_string_string_int",
ImmutableList.of(String.class, String.class, String.class, Long.class),
CelStringExtensions::replace)),
REVERSE(
CelFunctionDecl.newFunctionDeclaration(
"reverse",
CelOverloadDecl.newMemberOverload(
"string_reverse",
"Returns a new string whose characters are the same as the target string,"
+ " only formatted in reverse order.",
SimpleType.STRING,
SimpleType.STRING)),
CelFunctionBinding.from("string_reverse", String.class, CelStringExtensions::reverse)),
SPLIT(
CelFunctionDecl.newFunctionDeclaration(
"split",
Expand DownExpand Up@@ -449,6 +470,67 @@ private static Long lastIndexOf(CelCodePointArray str, CelCodePointArray substr,
return -1L;
}

private static String quote(String s) {
StringBuilder sb = new StringBuilder(s.length() + 2);
sb.append('"');
for (int i = 0; i < s.length(); ) {
int codePoint = s.codePointAt(i);
if (isMalformedUtf16(s, i, codePoint)) {
sb.append('\uFFFD');
Comment thread
pkwarren marked this conversation as resolved.
i++;
continue;
}
switch (codePoint) {
case '\u0007':
sb.append("\\a");
break;
case '\b':
sb.append("\\b");
break;
case '\f':
sb.append("\\f");
break;
case '\n':
sb.append("\\n");
break;
case '\r':
sb.append("\\r");
break;
case '\t':
sb.append("\\t");
break;
case '\u000B':
sb.append("\\v");
break;
case '\\':
sb.append("\\\\");
break;
case '"':
sb.append("\\\"");
break;
default:
sb.appendCodePoint(codePoint);
break;
}
i += Character.charCount(codePoint);
}
sb.append('"');
return sb.toString();
}

private static boolean isMalformedUtf16(String s, int index, int codePoint) {
char currentChar = s.charAt(index);
if (!Character.isValidCodePoint(codePoint)) {
return true;
}
if (Character.isLowSurrogate(currentChar)) {
return true;
}
// Check for unpaired high surrogate
return Character.isHighSurrogate(currentChar)
&& (index + 1 >= s.length() || !Character.isLowSurrogate(s.charAt(index + 1)));
}

private static String replaceAll(Object[] objects) {
return replace((String) objects[0], (String) objects[1], (String) objects[2], -1);
}
Expand DownExpand Up@@ -504,6 +586,10 @@ private static String replace(String text, String searchString, String replaceme
return sb.append(textCpa.slice(start, textCpa.length())).toString();
}

private static String reverse(String s) {
return new StringBuilder(s).reverse().toString();
}

private static List<String> split(String str, String separator) {
return split(str, separator, Integer.MAX_VALUE);
}
Expand Down
27 changes: 27 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -474,6 +474,19 @@ Examples:
'TacoCat'.lowerAscii() // returns 'tacocat'
'TacoCÆt Xii'.lowerAscii() // returns 'tacocÆt xii'

### Quote

Takes the given string and makes it safe to print (without any formatting due
to escape sequences).
If any invalid UTF-8 characters are encountered, they are replaced with \uFFFD.

strings.quote(<string>)

Examples:

strings.quote('single-quote with "double quote"') // returns '"single-quote with \"double quote\""'
strings.quote("two escape sequences \a\n") // returns '"two escape sequences \\a\\n"'

### Replace

Returns a new string based on the target, which replaces the occurrences of a
Expand All@@ -493,6 +506,20 @@ Examples:
'hello hello'.replace('he', 'we', 1) // returns 'wello hello'
'hello hello'.replace('he', 'we', 0) // returns 'hello hello'

### Reverse

Returns a new string whose characters are the same as the target string, only
formatted in reverse order.
This function relies on converting strings to Unicode code point arrays in
order to reverse.

<string>.reverse() -> <string>

Examples:

'gums'.reverse() // returns 'smug'
'John Smith'.reverse() // returns 'htimS nhoJ'

### Split

Returns a mutable list of strings split from the input by the given separator. The
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -168,6 +168,7 @@ public void getAllFunctionNames() {
"join",
"lastIndexOf",
"lowerAscii",
"strings.quote",
"replace",
"split",
"substring",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,8 @@
import dev.cel.runtime.CelEvaluationException;
import dev.cel.runtime.CelRuntime;
import dev.cel.runtime.CelRuntimeFactory;

import java.nio.charset.StandardCharsets;
import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand DownExpand Up@@ -70,7 +72,9 @@ public void library() {
"lastIndexOf",
"lowerAscii",
"replace",
"reverse",
"split",
"strings.quote",
"substring",
"trim",
"upperAscii");
Expand DownExpand Up@@ -1467,6 +1471,88 @@ public void stringExtension_functionSubset_success() throws Exception {
assertThat(evaluatedResult).isEqualTo(true);
}

@Test
@TestParameters("{string: 'abcd', expectedResult: 'dcba'}")
@TestParameters("{string: '', expectedResult: ''}")
@TestParameters("{string: 'a', expectedResult: 'a'}")
@TestParameters("{string: 'hello world', expectedResult: 'dlrow olleh'}")
@TestParameters("{string: 'ab가cd', expectedResult: 'dc가ba'}")
public void reverse_success(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: '😁😑😦', expectedResult: '😦😑😁'}")
@TestParameters("{string: '\u180e\u200b\u200c\u200d\u2060\ufeff', expectedResult: '\ufeff\u2060\u200d\u200c\u200b\u180e'}")
public void reverse_unicode(String string, String expectedResult) throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("s.reverse()").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
@TestParameters("{string: 'hello', expectedResult: '\"hello\"'}")
@TestParameters("{string: '', expectedResult: '\"\"'}")
@TestParameters("{string: 'contains \\\"quotes\\\"', expectedResult: '\"contains \\\\\\\"quotes\\\\\\\"\"'}")
Comment thread
pkwarren marked this conversation as resolved.
@TestParameters("{string: 'ends with \\\\', expectedResult: '\"ends with \\\\\\\\\"'}")
@TestParameters("{string: '\\\\ starts with', expectedResult: '\"\\\\\\\\ starts with\"'}")
public void quote_success(String string, String expectedResult) throws Exception {
Comment thread
pkwarren marked this conversation as resolved.
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval(ImmutableMap.of("s", string));

assertThat(evaluatedResult).isEqualTo(expectedResult);
}

@Test
public void quote_singleWithDoubleQuotes() throws Exception {
String expr = "strings.quote('single-quote with \"double quote\"')";
String expected = "\"\\\"single-quote with \\\\\\\"double quote\\\\\\\"\\\"\"";
CelAbstractSyntaxTree ast = COMPILER.compile(expr + " == " + expected).getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult = program.eval();

assertThat(evaluatedResult).isEqualTo(true);
}

@Test
public void quote_escapesSpecialCharacters() throws Exception {
CelAbstractSyntaxTree ast = COMPILER.compile("strings.quote(s)").getAst();
CelRuntime.Program program = RUNTIME.createProgram(ast);

Object evaluatedResult =
program.eval(
ImmutableMap.of(
"s", "\u0007bell\u000Bvtab\bback\ffeed\rret\nline\ttab\\slash 가 😁"));

assertThat(evaluatedResult)
.isEqualTo("\"\\abell\\vvtab\\bback\\ffeed\\rret\\nline\\ttab\\\\slash 가 😁\"");
}

@Test
public void quote_escapesMalformed_endWithHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "end with high surrogate \uD83D")))
.isEqualTo("\"end with high surrogate \uFFFD\"");
}

@Test
public void quote_escapesMalformed_unpairedHighSurrogate() throws Exception {
CelRuntime.Program program = RUNTIME.createProgram(COMPILER.compile("strings.quote(s)").getAst());
assertThat(program.eval(ImmutableMap.of("s", "bad pair \uD83DA")))
.isEqualTo("\"bad pair \uFFFDA\"");
}

@Test
public void stringExtension_compileUnallowedFunction_throws() {
CelCompiler celCompiler =
Expand Down
Loading