AttachmentContentStore - #276

Open
msladek wants to merge 40 commits into
devfrom
store-att-content
Open

AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom
store-att-content

Conversation

@msladek

@msladekmsladek commented Jan 13, 2026

Copy link
Copy Markdown
Member

No description provided.

msladekand others added 24 commits January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek changed the title Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek marked this pull request as ready for review January 15, 2026 11:03
@msladek
msladek requested a review from CopilotJanuary 15, 2026 11:03
@msladek
msladek requested a review from fpichlerJanuary 15, 2026 11:03
CopilotAI reviewed Jan 15, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.

Changes:

  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.

Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java Outdated
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java Outdated
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java Outdated
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java Outdated
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java
Base automatically changed from major-7 to devFebruary 2, 2026 18:31
@fpichlerfpichler assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
AttachmentContentStore - #276
Open
msladek wants to merge 40 commits into
devfrom 
store-att-content
Open
AttachmentContentStore#276
msladek wants to merge 40 commits into
devfrom 
store-att-content
Conversation
@msladek
@msladekmsladek
commented
Jan 13, 2026

Copy link


Copy Markdown

Member
 No description provided. 
msladekand others
added 24 commits
January 1, 2026 14:06
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
064d9fd
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d9b2fa0
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
3ec8fc4
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
883c6df
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
c701171
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
e41cff2
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
85eb796
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d91f5ec
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbaf3a7
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
d85d637
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
944d1c9
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
403d12b
@msladek
[prepare-major] update to major version 7.0-SNAPSHOT
dbf6f7d
@msladek
fix DefaultDocumentCacheTest
2a86364
@msladek
remove illegal config
afd8475
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
a20d6fe
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
05e8ee9
@msladek
fix PluginManager
812fe68
@fpichler
Merge branch 'dev' into major-7
c89ba6e
@msladek
Merge branch 'dev' into major-7
6b6dedd
@msladek
s3 test
3660b9a
@msladek
AttachmentContentStore
d7c9e6a
@msladek
Merge remote-tracking branch 'origin/dev' into major-7
f861364
@msladek
Merge branch 'major-7' into s3
3c0c0df
@msladekmsladek
changed the title
Store att contentAttachmentContentStoreJan 13, 2026
@msladek
msladek
marked this pull request as ready for review
January 15, 2026 11:03
@msladek
msladek
requested a review
from CopilotJanuary 15, 2026 11:03
@msladek
msladek
requested a review
from fpichlerJanuary 15, 2026 11:03
CopilotAI
reviewed
Jan 15, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This pull request introduces a new abstraction layer for attachment content storage in XWiki, separating the concerns of attachment content storage from the overall attachment store implementation. The changes enable pluggable storage backends (e.g., object storage like S3) as alternatives to the legacy Hibernate-based database storage for attachment binary content.
Changes:
  • Introduced new AttachmentContentStore interface and HibernateAttachmentContentStore implementation to abstract attachment content persistence
  • Refactored XWikiHibernateAttachmentStore to delegate content operations to pluggable stores with fallback support for migration scenarios
  • Removed XWikiContext parameter from multiple AttachmentVersioningStore methods, modernizing the API to use execution context directly
  • Added AttachmentContentPolicy to control whether attachment content should be embedded in XML structures (RCS archives, recycle bin) based on the active content store
  • Migrated logging from Apache Commons Logging to SLF4J across multiple classes
  • Removed obsolete VoidAttachmentVersioningStoreTest test file
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.
Show a summary per file
FileDescription
XWikiHibernateAttachmentStore.javaRefactored to use pluggable content/versioning stores with fallback mechanism
HibernateAttachmentContentStore.javaNew implementation of AttachmentContentStore for Hibernate-based persistence
AttachmentContentStore.javaNew interface defining content store contract with custom exception type
AttachmentVersioningStore.javaRemoved XWikiContext from method signatures, added hasVersioning() method
HibernateAttachmentVersioningStore.javaUpdated to use execution context instead of XWikiContext
VoidAttachmentVersioningStore.javaUpdated method signatures and simplified implementation
AttachmentContentPolicy.javaNew policy component to control content embedding in XML structures
StoreFactory.javaAdded factory methods for attachment content and versioning stores
XWikiHibernateBaseStore.javaAdded getXContext() helper and cfgSrc dependency injection
XWikiAttachment.javaRefactored to remove XWikiContext dependencies, added toString() override
XWikiAttachmentArchive.javaUpdated to use policy for content embedding decisions
XWikiAttachmentContent.javaChanged getSize() return type from int to long
DeletedAttachment.javaChanged constructor to use boolean flag instead of XWikiContext
Various logging classesMigrated from Commons Logging to SLF4J
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Outdated

Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java
Comment threadcelements-xwiki-core/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java

Base automatically changed from
major-7 to
devFebruary 2, 2026 18:31
@fpichlerfpichler
assigned msladek and unassigned fpichlerFeb 6, 2026
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@fpichlerfpichlerfpichler approved these changes

Assignees

@msladekmsladek

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@msladek@fpichler