Set up graph_query testing infrastructure for task graph by psalz · Pull Request #325 · celerity/celerity-runtime

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

psalz · 2024-12-23T13:20:33Z

This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for task_record, but since unlike for commands and instructions, a call to submit() only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.

github-actions · 2024-12-23T13:21:20Z

Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions

⚠️Clang-Tidy found issue(s) with the introduced code (1/1)

github-actions · 2024-12-23T13:27:50Z

- fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin));
- }
+	for(const auto& tsk : recorder.get_graph_nodes()) {
+ const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded";


⚠️misc-const-correctness⚠️
variable shape of type const char * can be declared const

github-actions · 2024-12-23T13:27:50Z

-	template <int Dims, typename Handler, typename Functor>
-void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) {
+	template <typename Builder, int Dims, typename Functor>
+auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) {


⚠️cppcoreguidelines-missing-std-forward⚠️
forwarding reference parameter builder is never forwarded inside the function body

github-actions · 2024-12-23T13:27:50Z


- [[maybe_unused]] const task_id tid_8 =
- test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); });
+ const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit();


⚠️clang-analyzer-deadcode.DeadStores⚠️
Value stored to tid_8 during its initialization is never read

coveralls · 2024-12-23T13:33:41Z

Pull Request Test Coverage Report for Build 15470784509

Details

33 of 33(100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on tdag-testing-infrastructure at 95.05%

Totals
Change from base Build 15412343516:	95.1%
Covered Lines:	7146
Relevant Lines:	7250

💛 - Coveralls

fknorr

Very cool! This makes me want to start the TDAG refactor.

fknorr · 2025-01-16T12:58:55Z

+// TODO: Can we make this the base class of cdag / idag test contexts?
+class tdag_test_context final : private task_manager::delegate {


How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.

…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

github-actions · 2025-06-05T15:17:26Z

Check-perf-impact results: (17d2daea565336edd0421cacd8138ced)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

github-actionsBot reviewed Dec 23, 2024
View reviewed changes

GagaLP approved these changes Jan 7, 2025
View reviewed changes

fknorr approved these changes Jan 16, 2025
View reviewed changes

psalzand others added 3 commits June 5, 2025 14:35

Set up graph_query testing infrastructure for task graph
df60b9b

Convert all task graph tests to builder pattern + query
2230e24

Address Clang-Tidy suggestions: misc-const-correctness, cppcoreguidel…
229761d
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores

GagaLP force-pushed the tdag-testing-infrastructure branch from ab1c78b to 229761dCompare June 5, 2025 15:15

		// TODO: Can we make this the base class of cdag / idag test contexts?
		class tdag_test_context final : private task_manager::delegate {

Uh oh!

Conversation

psalz commented Dec 23, 2024

Uh oh!

github-actionsBot commented Dec 23, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotDec 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotDec 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotDec 23, 2024

Choose a reason for hiding this comment

Uh oh!

coveralls commented Dec 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 15470784509

Details

💛 - Coveralls

Uh oh!

fknorr left a comment

Choose a reason for hiding this comment

Uh oh!

fknorrJan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

psalz commented Dec 23, 2024

Uh oh!

github-actionsBot commented Dec 23, 2024

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotDec 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotDec 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actionsBotDec 23, 2024

Choose a reason for hiding this comment

Uh oh!

coveralls commented Dec 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 15470784509

Details

💛 - Coveralls

Uh oh!

fknorr left a comment

Choose a reason for hiding this comment

Uh oh!

fknorrJan 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Dec 23, 2024•
edited
Loading

coveralls commented Dec 23, 2024•
edited
Loading

coveralls commented Dec 23, 2024•
edited
Loading