Skip to content

Include PDF/A color profile in renderer image - #56

Merged
JustAGhosT merged 2 commits into
mainfrom
fix/pdfa-runtime-profile
Aug 28, 2026
Merged

Include PDF/A color profile in renderer image#56
JustAGhosT merged 2 commits into
mainfrom
fix/pdfa-runtime-profile

Conversation

@JustAGhosT

Copy link
Copy Markdown
Collaborator

CoilTrace production acceptance reached Mill but every certificate conversion returned success=false. The live revision and exact image digest were verified, and an in-container kpsewhich lookup confirmed that sRGB_IEC61966-2-1_black_scaled.icc is absent. pdfx requires that profile. Install Debian's icc-profiles package and change the Docker smoke test to compile an actual PDF/A-2b document, so this runtime dependency cannot pass image CI unchecked again.

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JustAGhosT has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitaiBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1af96e9-fbde-4168-bc1b-22587b279dfc

📥 Commits

Reviewing files that changed from the base of the PR and between c09e43b and d608851.

📒 Files selected for processing (1)
  • backend/Dockerfile

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: build-api
  • GitHub Check: Kilo Code Review
🔇 Additional comments (1)
backend/Dockerfile (1)

15-15: 🗄️ Data Integrity & Integration

No change needed for ICC profile resolution.

icc-profiles-free does not contain the profile, but texlive-latex-extra provides it in TeX’s search path. The production renderer also invokes /usr/bin/pdflatex, so the smoke test exercises the same lookup mechanism. The repository does not require the profile at /usr/share/color/icc/....


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved PDF/A-2b validation in the TeX smoke test.
    • Added support for ICC color profiles to improve PDF generation compatibility.

Walkthrough

The Docker image installs ICC profiles. The TeX smoke test now generates PDF/A-2b metadata with pdfx instead of loading hyperref directly.

Changes

PDF/A Smoke Test

Layer / File(s)Summary
Image dependency and PDF/A smoke test
backend/Dockerfile
The image installs icc-profiles-free. The TeX smoke test writes XMP metadata and validates PDF/A-2b output with pdfx.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk:⚪ Minimal · up to d6088

The Dockerfile change is localized to the renderer’s PDF/A dependency and smoke test, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: adding the required PDF/A color profile to the renderer image.
Description check✅ PassedThe description directly explains the missing ICC profile, the package installation, and the PDF/A-2b smoke-test update.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pdfa-runtime-profile

Comment @coderabbitai help to get the list of available commands.

@JustAGhosT
JustAGhosT merged commit b7d8bc5 into mainAug 28, 2026
11 checks passed
@JustAGhosT
JustAGhosT deleted the fix/pdfa-runtime-profile branch August 28, 2026 00:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@JustAGhosT