Fix undeclared reference assignment - #22
Closed
mglazer-cengage wants to merge 2 commits into
Closed
Conversation
Added var declaration to make it strict mode compliant
Fix undeclared reference assignment
uiteoi
commented
Jun 5, 2017
This needs to be merged. Is this repo still active? If not, would you consider adding maintainers? |
cemerick added a commit
that referenced
this pull request
Jun 5, 2017
cemerick added a commit
that referenced
this pull request
Jun 5, 2017
cemerick
commented
Jun 5, 2017
Owner
Bizarrely, I wasn't able to merge this cleanly, it reported conflicts? Anyway, applied the change directly since it was so simple; I'm sorry about the loss of "authorship" info in the history. :-| |
cemerick
commented
Jun 5, 2017
Owner
@uiteoi BTW, no, this repo isn't particularly active. I merge things as they come by / as I notice them. Please feel free to fork. |
abbaskiko added a commit
to abbaskiko/jsdifflib
that referenced
this pull request
Sep 17, 2021
declare diffview var, fixescemerickgh-21 and cemerickgh-22
hhjmmmmmmmm
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not pass babel strict mode.
ReferenceError: Strict mode forbids implicit creation of global property 'diffview'