Perf/optimizations - #1
Merged
Merged
Conversation
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
…nker Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
Co-Authored-By: Spettro <spettro@eyed.to>
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts the native library from 41 MB to 23.5 MB per ABI (−43%; arm64 APK 37 → 10.6 MB) and removes the
main runtime hot-spots: per-keystroke JNI window re-marshaling, whole-subtree recompositions, always-on
background polling, and redundant
gitruns under proot. Also adds a committed baseline profile so coldstart runs AOT-compiled code.
Type of change
Architecture & conventions checklist
core/); UI/platform stays in Kotlin (app/)core/crates/jni-bridge/src/lib.rsandapp/…/core/CoreBridge.ktwere updated togetherdocs/SHORTCUTS.mdupdated if new shortcuts/commands were addedEdition impact
full(Debian userland,apt, F-Droid/direct APK)play(Play-compatible, no userland)Testing
./gradlew assembleFullDebug assemblePlayDebugcd core && cargo testcd core && cargo clippytools/fold-emulator.sh)Device tested on (if applicable):
Samsung Galaxy Fold 8 Ultra (outer and inner screen)
Notes: engine suite is 271 tests (new coverage for the window cache, cached HEAD/branch reads, and ACP
version counters).
cargo clippyexits clean; three warning sites remain inproject.rs/highlight.rsthat pre-exist on
main. One pre-existing LSP-budget test flakes under full parallel load only.Baseline profile was generated on a headless Gradle-managed device (
pixel6Api36), not the foldableemulator. Behavior notes for review:
panic = "abort"now ends the process on an engine panic (logcatmessage first), and gpui's image/SVG decoding is behind an off-by-default feature (Compose does all real
media rendering).
Screenshots / recordings
No visual changes, title bar (branch + drift arrows), terminal theming, and editor rendering are
pixel-identical by design.
Related issues
none