fix(vue): presence onExitComplete & types - #1939
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iamdin
commented
Dec 30, 2023
iamdin
force-pushed
the
fix/vue-presence
branch
from
December 30, 2023 05:22
c0cd15d to
f5a0543
Compare
iamdin
commented
Dec 30, 2023
| default: undefined, | ||
| }, | ||
| }, | ||
| emits, |
Contributor
Author
There was a problem hiding this comment.
As we use Function Signature to define component, I don't think we need to declare emit to get the type hint of event, because they already exist in the definition of zag
Contributor
There was a problem hiding this comment.
Good work with cleaning props in the component.
I'm not sure if emits are needed in components
Omikorin
reviewed
Dec 30, 2023
| default: undefined, | ||
| }, | ||
| }, | ||
| emits, |
Contributor
There was a problem hiding this comment.
Good work with cleaning props in the component.
I'm not sure if emits are needed in components
Omikorin
force-pushed
the
fix/vue-presence
branch
from
January 2, 2024 15:18
3a5bd27 to
7ad6aca
Compare
Contributor
|
@iamdin I've reverted what should be reverted. Thanks! |
Contributor
Author
Thanks！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onExitCompletecannot call correctlytoValue