fix(vue): remove removed portalled prop from popover - #4088
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Adebesin-Cell has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Adebesin-Cell
force-pushed
the
fix/vue-popover-portalled
branch
from
September 19, 2026 04:31
23769bb to
70af867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Removes the
portalledprop from Vue'sPopover.Root, aligning it with zag v2 and the other frameworks.⛳️ Current behavior
zag v2 removed
portalled(portalling is auto-detected from where the content is rendered), and React, Solid, and Svelte already dropped it. Vue still declaredportalled?: booleanand defaulted it — dead surface that did nothing, since the machine ignores it. It wasn't caught by typecheck because Vue declares props locally instead of extending zag's types.🚀 New behavior
Popover.Rootno longer acceptsportalled. Decide portalling by rendering the content insidePortalor not.🧩 Frameworks
💣 Is this a breaking change (Yes/No): No
✅ Checklist