Skip to content

Use node16 in actions - #216

Merged
Andarist merged 3 commits into
changesets:mainfrom
quinnjn:main
Sep 15, 2022
Merged

Use node16 in actions#216
Andarist merged 3 commits into
changesets:mainfrom
quinnjn:main

Conversation

@quinnjn

@quinnjnquinnjn commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Bumps the action to use node16

@changeset-bot

changeset-botBot commented Sep 14, 2022•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c718e2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Andarist
Andarist reviewed Sep 14, 2022
View reviewed changes
Comment threadpackage.json Outdated
Andarist
Andarist previously approved these changes Sep 14, 2022
View reviewed changes
@Andarist

Andarist commented Sep 14, 2022

Copy link
Copy Markdown
Member

We should also update those 2 places:

@Andarist
Andarist dismissed their stale reviewSeptember 14, 2022 22:03

GitHub workflows need to be fixed

Andarist
Andarist reviewed Sep 15, 2022
View reviewed changes
Comment threadpackage.json Outdated
@Andarist
Andarist merged commit 398d7ed into changesets:mainSep 15, 2022
@glasser

glasser commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

How do we update to get this (and stop the deprecation warning)? It's not on the v1 branch, but I don't think there is a v2 branch?

@Andarist

Andarist commented Oct 11, 2022

Copy link
Copy Markdown
Member

@glasser could you prepare a PR with a changeset describing this change?

@glasser

glasser commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

A PR into the v1 branch? Just cherry-picking this?

Or do you mean just adding a single .changeset file to main?

@Andarist

Andarist commented Oct 12, 2022

Copy link
Copy Markdown
Member

Or do you mean just adding a single .changeset file to main?

This. Releases here are done based on the main branch - we need to create a versioning PR and land it to kick off the release

glasser added a commit to glasser/action that referenced this pull request Oct 12, 2022
@glasser
Create changeset forchangesets#216
5cb5b4e
@glasser

glasser commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Gotcha. Made #223. I see my last change is also ready to go :)

@kachkaevkachkaev mentioned this pull request Oct 14, 2022
Closed
Andarist added a commit that referenced this pull request Nov 2, 2022
@glasser@Andarist
Create changeset for#216(#223)
8ec7804
* Create changeset for #216
* Tweak changeset
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 2, 2022
Merged
@trivikrtrivikr mentioned this pull request Nov 17, 2022
Closed
quinnjn pushed a commit to quinnjn/changesets-action that referenced this pull request Jan 11, 2023
@glasser@Andarist@quinnjn
Create changeset forchangesets#216(changesets#223)
5898e1f
* Create changeset for changesets#216
* Tweak changeset
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndaristAndaristAndarist left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quinnjn@Andarist@glasser