Allow time scale to offset using skipped ticks - #10278
Merged
etimberg merged 1 commit intoApr 3, 2022
Merged
Conversation
Member
|
Could be also a new value for the existing |
kurkle
approved these changes
Apr 3, 2022
kurkle
left a comment
Member
There was a problem hiding this comment.
Does it break many fixtures if this would be default? Just wondering if the option could be avoided.
In case the option is needed, the suggested one is fine by me.
Member
Author
|
Setting this as the default breaks 2 fixtures |
Member
Author
|
One of those changes is pretty big |
Member
|
That one does not have any ticks, so could maybe be worked around.. But anyway, I think its safer to have the new option. |
Member
Author
|
I agree, a new option makes more sense. We can change the default at v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10215 using a new option for time scales called
offsetAfterAutoskip.If there are better option names, we can use that too. Perhaps an
offsetTickssetting with two options:'all'and'skipped'