Resolve canvasGradient is undefined in node - #10328
Merged
Merged
Conversation
etimberg
previously approved these changes
Apr 29, 2022
amitkumarhq
approved these changes
May 1, 2022
etimberg
previously approved these changes
May 1, 2022
Member
|
Sure, we could add an export here |
Collaborator
Author
|
Will update PR to export function and typings tomorrow |
amitkumarhq
approved these changes
May 2, 2022
amitkumarhq
approved these changes
May 2, 2022
amitkumarhq
previously approved these changes
May 2, 2022
LeeLenaleee
dismissed stale reviews from amitkumarhq, kurkle, and etimberg
via
May 2, 2022 21:08
6a6270f
Collaborator
Author
|
@amitkumarhq leaving a review or approval on the code once is fine but please dont spam approvals, approving 3 times within 17 minutes and then again after 14.5 hours won't help, it only iritates people as they will get notifications from it. So please consider that we also have normal lives, that this is volunteer work and we can't always implement feedback right the second we see it. |
etimberg
previously approved these changes
May 2, 2022
kurkle
reviewed
May 2, 2022
etimberg
approved these changes
May 3, 2022
kurkle
approved these changes
May 3, 2022
amitkumarhq
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10327