Types: Allow font to be partial scriptable and individually scriptable - #10364
Merged
Merged
Conversation
Collaborator
Author
|
Not really happy about the approach especially the CanvasFontSpec but didn't know an other/better way to achieve the desired behaviour |
kurkle
reviewed
May 21, 2022
Collaborator
Author
|
From the bit of testing I did it seemed like it. But will test it bit more when I get back from vacation in a few days. |
etimberg
reviewed
May 21, 2022
syedabdullahali
previously approved these changes
May 24, 2022
LeeLenaleee
commented
May 25, 2022
LeeLenaleee
left a comment
Collaborator
Author
There was a problem hiding this comment.
Rename for consitency with ScriptableAndArray
etimberg
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10363