Fix permissions - #10642
Merged
Merged
Fix permissions#10642
Conversation
kurkle
approved these changes
Aug 31, 2022
etimberg
approved these changes
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permissions:is not a valid element ofreleasetrigger. This is whycontents: readwas mistakenly removed as redundant in #10513. Instead of definingreadonly for all job, butwriteto thereleasejob. It was justreadonly for all jobs and it was failing. After removal of the default permission it is using the default extended set of permissions.The PR fixes the default permission and correctly assigns write permission only to the release job.