Fix issue #5029 - infinite loop due to insufficient bounds checking - #5041
Merged
Merged
Conversation
- infinite loop in generating time axis, due to insufficient bounds checking.
etimberg
approved these changes
Dec 14, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
- infinite loop in generating time axis, due to insufficient bounds checking.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
- infinite loop in generating time axis, due to insufficient bounds checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While generating the time axis, a negative
stepSizewill result in an infinite loop.A negative
stepSizecould be generated bydetermineStepSizewhen thecapacityargument is also negative. This PR will havegetLabelCapacityalways return a positivecapacityand clean up a previous check indetermineStepSize.fiddle https://jsfiddle.net/aLk05ptk/10/
Fixes #5029