Skip to content

Return Vec from dc_get_chat_contacts - #334

Merged
Jikstra merged 1 commit into
chatmail:masterfrom
link2xt:dc_get_chat_contacts_vec
Aug 13, 2019
Merged

Return Vec from dc_get_chat_contacts#334
Jikstra merged 1 commit into
chatmail:masterfrom
link2xt:dc_get_chat_contacts_vec

Conversation

@link2xt

@link2xtlink2xt commented Aug 11, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

@link2xtlink2xt mentioned this pull request Aug 11, 2019
Merged
dignifiedquire
dignifiedquire reviewed Aug 11, 2019
View reviewed changes
Comment threadsrc/dc_chat.rs Outdated
link2xt
link2xt commented Aug 12, 2019
View reviewed changes
Comment threadsrc/dc_chat.rs Outdated
@Jikstra

Jikstra commented Aug 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

For the ffi we need to convert the Vec to dc_array_t, otherwise this breaks the bindings.
This conflicts with my pr to fix a panic in the node bindings #346

@link2xtlink2xt mentioned this pull request Aug 12, 2019
Closed
@link2xtlink2xt changed the title Return Vec from dc_get_chat_contactsWIP: Return Vec from dc_get_chat_contactsAug 12, 2019
@link2xt

link2xt commented Aug 12, 2019

Copy link
Copy Markdown
CollaboratorAuthor

WIP because I want to use #347 here, need to get it merged first

@link2xtlink2xt mentioned this pull request Aug 12, 2019
Merged
@link2xtlink2xt changed the title WIP: Return Vec from dc_get_chat_contactsReturn Vec from dc_get_chat_contactsAug 12, 2019
@link2xt
link2xt requested a review from JikstraAugust 12, 2019 23:38
@Jikstra
Jikstra merged commit ab022cc into chatmail:masterAug 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dignifiedquiredignifiedquireAwaiting requested review from dignifiedquire
1 more reviewer
@JikstraJikstraJikstra approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@link2xt@Jikstra@dignifiedquire