Uh oh!
There was an error while loading. Please reload this page.
refactor: rename automatic_relay_management to autorelay - #8623
Merged
Conversation
hpk42
commented
Aug 24, 2026
| .get_config_i64(Config::LastAutomaticRelayManagement) | ||
| .await | ||
| .unwrap(); | ||
| let config_before = t.get_config_i64(Config::LastAutorelay).await.unwrap(); |
ContributorAuthor
There was a problem hiding this comment.
renaming configs is fine IMHO. No UI uses them, and the commit marks the refactor as breaking.
Hocuri
approved these changes
Aug 27, 2026
Hocuri
left a comment
Collaborator
There was a problem hiding this comment.
I don't think this should be marked as "breaking", because we generally treat "breaking change" to mean "UIs need to adapt", and while this does rename a config, we didn't tell any UIs about this config, so that practically, it's not a breaking change.
If it's marked as "breaking", it will prominently appear in the changelog and UIs will wonder what they need to do.
hpk42force-pushed
the
hpk/rename-autorelay
branch
from
August 27, 2026 14:25
74998fa to
b541141Comparehpk42
enabled auto-merge (rebase)
August 27, 2026 14:25
"automatic_relay_management" is a long unwiedly name with no UI using the mode yet, so let's rename it to something more succinct: autorelay
hpk42force-pushed
the
hpk/rename-autorelay
branch
from
August 27, 2026 14:38
b541141 to
ff33ff4CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"management" is usually good to avoid in any name, and "automatic_relay_management" is a long unwiedly name with no UI using the mode yet, so let's rename it to something more succinct: autorelay
also added a small module docstring to
src/autorelay.rsfrom what i captured.