Uh oh!
There was an error while loading. Please reload this page.
fix: do not mark call message as seen when declining a call - #8633
fix: do not mark call message as seen when declining a call#8633link2xt wants to merge 1 commit into
Conversation
When the message is marked as seen, an MDN (read receipt) is sent to self and receiving such MDN marks all messages in the chat above the call message as noticed. Calls may be declined from the notification, so user may decline a call without ever seeing a call message in the chat.
49467e9 to
3784b3eCompare
hpk42
left a comment
There was a problem hiding this comment.
I am afraid I don't quite get the overall scheme of how caller/callee and their multi-device setups are meant to land in consistent states including UI notifications/interactions. I filed an issue #8635 and is it not strictly related to this particular PR.
For this PR my main concern is that the second device of the Callee might be left with a "Missed call" notifcation if there is no self-MDN anymore. As far as i see, at receiving time, a stale-on-arrival call notifies via
Lines 368 to 372 in 3784b3e
The accepted-call path should probably be handled before #8631 can be closed but it doesn't necessarily block this PR i guess.
| if chat.is_contact_request() { | ||
| chat.id.accept(self).await?; | ||
| } | ||
| markseen_msgs(self, vec![call_id]).await?; |
There was a problem hiding this comment.
isn't this the same problem?
i guess there should be a helper that both declining and accept call use.
| (MessageState::InNoticed, call_id, MessageState::InFresh), | ||
| ) | ||
| .await | ||
| .context("Failed to mark incoming call as noticed")?; |
There was a problem hiding this comment.
This by itself does not send out anything, right?
When the message is marked as seen, an MDN (read receipt) is sent to self
and receiving such MDN marks all messages in the chat above the call message as noticed.
Calls may be declined from the notification, so user may decline a call
without ever seeing a call message in the chat.
Closes#8631