Fix vmware-iso validation by explicitly setting tools_mode - #1673
Merged
Merged
Conversation
|
Collaborator
|
now that they have attach fixed I think this should default to attach. upload was only used as it was the only one supported for all platforms. Attach speeds things up since it doesn't have to spend the time copying the iso to the server. |
Stromweld
reviewed
May 1, 2026
Stromweld
force-pushed
the
fix/vmware-tools-mode
branch
from
May 1, 2026 12:57
4761120 to
2a47574
Compare
|
Signed-off-by: Takashi Matsumoto <tmtsmt.sec@gmail.com>
Stromweld
force-pushed
the
fix/vmware-tools-mode
branch
from
May 27, 2026 21:12
2a47574 to
ff5a46f
Compare
- Change tools_mode default from 'upload' to 'attach' for better performance
- Add tools_source_path with smart defaults based on host OS and guest type
- Automatically detects VMware Fusion paths on macOS
- Automatically detects VMware Workstation paths on Linux
- Handles x86_64 and aarch64 architectures
- Correctly selects windows.iso, linux.iso, or darwin.iso based on guest type
- Implement proper mutual exclusivity per VMware plugin documentation:
- tools_source_path: Can be used with both 'attach' and 'upload' modes
- tools_upload_flavor: Only used when tools_mode is 'upload' AND
tools_source_path is null
- These two options cannot be used together per plugin requirements
- Make tools_upload_path conditional (only set when tools_mode is 'upload')
- Add helpful descriptions to all VMware tools variables
- Allow user overrides of all settings via variables
This improves on the original PR by defaulting to the faster 'attach' mode
instead of 'upload' mode, while properly implementing the mutual exclusivity
requirements from the Packer VMware plugin documentation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Stromweld
force-pushed
the
fix/vmware-tools-mode
branch
from
May 27, 2026 21:48
daa601e to
4103f97
Compare
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
SamuelMarks
pushed a commit
to SamuelMarks/bento
that referenced
this pull request
Aug 21, 2026
* Fix vmware-iso validation by explicitly setting tools_mode
Signed-off-by: Takashi Matsumoto <tmtsmt.sec@gmail.com>
* Improve VMware tools configuration for better performance
- Change tools_mode default from 'upload' to 'attach' for better performance
- Implement proper mutual exclusivity per VMware plugin documentation:
- tools_source_path: Can be used with both 'attach' and 'upload' modes
- tools_upload_flavor: Only used when tools_mode is 'upload' AND
tools_source_path is null
- These two options cannot be used together per plugin requirements
- Make tools_upload_path conditional (only set when tools_mode is 'upload')
- Allow user overrides of all settings via variables
This improves on the original PR by defaulting to the faster 'attach' mode
instead of 'upload' mode, while properly implementing the mutual exclusivity
requirements from the Packer VMware plugin documentation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
* clean up tools code
* update vmware tools install scripts
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
---------
Signed-off-by: Takashi Matsumoto <tmtsmt.sec@gmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Co-authored-by: Corey Hemminger <hemminger@hotmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes
vmware-isovalidation when VMware tools upload settings are configured.Bento already sets
tools_upload_flavorandtools_upload_pathfor VMware builds, but does not settools_mode. With current VMware builder validation,tools_modemust be explicitly specified whenever tools configuration is present.Without this change, validation fails with the following error:
This PR adds a
vmware_tools_modevariable, derives a default value from the existing upload configuration, and passestools_modeto thevmware-isosource.The default behavior remains the same:
uploadwhen a VMware tools upload flavor is configureddisablewhen no upload flavor is availablevmware_tools_modeRelated Issue
No related issue.
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.