fix: sudo not preseving passed in environment variables - #1691
Merged
Conversation
This mainly effects Ubuntu 26.04, but could affect any distribution that decides to disable `-E` on sudo in a similar manner. Passing the environment variables through after the sudo guarantees they will be preserved in any executed script. Signed-off-by: Sn0wCrack <442287+Sn0wCrack@users.noreply.github.com>
11 tasks
Stromweld
approved these changes
Jul 20, 2026
SamuelMarks
pushed a commit
to SamuelMarks/bento
that referenced
this pull request
Aug 21, 2026
This mainly effects Ubuntu 26.04, but could affect any distribution that decides to disable `-E` on sudo in a similar manner. Passing the environment variables through after the sudo guarantees they will be preserved in any executed script. Signed-off-by: Sn0wCrack <442287+Sn0wCrack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly effects Ubuntu 26.04, but could affect any distribution that decides to disable
-Eon sudo in a similar manner.Passing the environment variables through after the sudo guarantees they will be preserved in any executed script.
Description
Ubuntu 26.04 currently fails on several scripts that use the
PACKER_environment variables, or any other environment variable passed in via the shell provision's environment variables option.Related Issue
See: #1689 (comment)
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.